Sign upLogin

concord-consortium/rigse

View on GitHub
Star
rails/app/assets/javascripts/jshowoff.js

Summary

Maintainability
C
1 day
Test Coverage

Function jshowoff has 150 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $.fn.jshowoff = function(settings) {

        // default global vars
        var config = {
            animatePause : true,
Severity: Major
Found in rails/app/assets/javascripts/jshowoff.js - About 6 hrs to fix

    Function transitionTo has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                function transitionTo(gallery,index) {
                
                var oldCounter = counter;
                if((counter >= gallery.length) || (index >= gallery.length)) { counter = 0; var e2b = true; }
                else if((counter < 0) || (index < 0)) { counter = gallery.length-1; var b2e = true; }
    Severity: Minor
    Found in rails/app/assets/javascripts/jshowoff.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              $('.'+uniqueClass+'-play').text(config.controlText.pause).removeClass('jshowoff-paused '+uniqueClass+'-paused');
      Severity: Minor
      Found in rails/app/assets/javascripts/jshowoff.js and 1 other location - About 35 mins to fix
      rails/app/assets/javascripts/jshowoff.js on lines 176..176

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if(!src || src=='playBtn') $('.'+uniqueClass+'-play').text(config.controlText.play).addClass('jshowoff-paused '+uniqueClass+'-paused');
      Severity: Minor
      Found in rails/app/assets/javascripts/jshowoff.js and 1 other location - About 35 mins to fix
      rails/app/assets/javascripts/jshowoff.js on lines 168..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              if($(this).hasClass('jshowoff-next')) $(this).click(function(){ next(); return false; });
      Severity: Minor
      Found in rails/app/assets/javascripts/jshowoff.js and 1 other location - About 30 mins to fix
      rails/app/assets/javascripts/jshowoff.js on lines 221..221

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              if($(this).hasClass('jshowoff-prev')) $(this).click(function(){ previous(); return false; });
      Severity: Minor
      Found in rails/app/assets/javascripts/jshowoff.js and 1 other location - About 30 mins to fix
      rails/app/assets/javascripts/jshowoff.js on lines 222..222

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status