connectbot/sshlib

View on GitHub

Showing 245 of 415 total issues

Method sendMessage has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

private final void sendMessage(int type, int requestId, byte[] msg, int off, int len) throws IOException
Severity: Minor
Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java - About 35 mins to fix

    Method read has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    public int read(SFTPv3FileHandle handle, long fileOffset, byte[] dst, int dstoff, int len) throws IOException
    Severity: Minor
    Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java - About 35 mins to fix

      Method write has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      public void write(SFTPv3FileHandle handle, long fileOffset, byte[] src, int srcoff, int len) throws IOException
      Severity: Minor
      Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java - About 35 mins to fix

        Method getChannelData has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        public int getChannelData(Channel c, boolean extended, byte[] target, int off, int len) throws IOException
        Severity: Minor
        Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 35 mins to fix

          Method resizePTY has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          public void resizePTY(Channel c, int term_width_characters, int term_height_characters,
          int term_width_pixels, int term_height_pixels) throws IOException {
          Severity: Minor
          Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 35 mins to fix

            Method calculateH has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            public byte[] calculateH(byte[] clientversion, byte[] serverversion, byte[] clientKexPayload,
            byte[] serverKexPayload, byte[] hostKey) throws UnsupportedEncodingException
            Severity: Minor
            Found in src/main/java/com/trilead/ssh2/crypto/dh/GenericDhExchange.java - About 35 mins to fix

              Method readLink has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              public String readLink(String path) throws IOException
              {
              int req_id = generateNextRequestID();
               
              TypesWriter tw = new TypesWriter();
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java - About 35 mins to fix

              Method canonicalPath has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              public String canonicalPath(String path) throws IOException
              {
              int req_id = generateNextRequestID();
               
              TypesWriter tw = new TypesWriter();
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/SFTPv3Client.java - About 35 mins to fix

              Method readOid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              public String readOid() throws IOException
              {
              int type = readByte() & 0xff;
               
              if (type != 0x06)
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/crypto/SimpleDERReader.java - About 35 mins to fix

              Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              private void initialize(char[] knownHostsData) throws IOException
              {
              BufferedReader br = new BufferedReader(new CharArrayReader(knownHostsData));
               
              while (true)
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/KnownHosts.java - About 35 mins to fix

              Method msgChannelData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              public void msgChannelData(byte[] msg, int msglen) throws IOException
              {
              if (msglen <= 9)
              throw new IOException("SSH_MSG_CHANNEL_DATA message has wrong size (" + msglen + ")");
               
               
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/channel/ChannelManager.java - About 35 mins to fix

              Method receiveLine has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              private String receiveLine(InputStream is) throws IOException
              {
              StringBuffer sb = new StringBuffer(30);
               
              while (true)
              Severity: Minor
              Found in src/main/java/com/trilead/ssh2/SCPClient.java - About 35 mins to fix

              Avoid too many return statements within this method.
              Open

              return;
              Severity: Major
              Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                return;
                Severity: Major
                Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                  return;
                  Severity: Major
                  Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                    return;
                    Severity: Major
                    Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                      return;
                      Severity: Major
                      Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                        return len;
                        Severity: Major
                        Found in src/main/java/com/trilead/ssh2/crypto/SimpleDERReader.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                          return;
                          Severity: Major
                          Found in src/main/java/com/trilead/ssh2/channel/AuthAgentForwardThread.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                            return;
                            Severity: Major
                            Found in src/main/java/com/trilead/ssh2/transport/KexManager.java - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language