Sign upLogin

conroywhitney/gringotts

View on GitHub
Star

Showing 3 of 3 total issues

Method attempt has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def attempt
      if accepts_strong_params?
        @attempt.assign_attributes(attempt_params)
      else
        @attempt.update_attributes(code_received: params[:attempt][:code_received])
Severity: Minor
Found in app/controllers/gringotts/verification_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method gringotts_protego! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def gringotts_protego!
      # check to see if we should be protecting in the first place
      # maybe not, depending on config/gringotts.yml and user status
      if gringotts_protego?
        # find or create a vault for this owner
Severity: Minor
Found in app/helpers/gringotts/gringotts_helper.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method successful? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def successful?
      
      if self.matches?
        if self.stale?
          self.mark_unsuccessful("Code expired")
Severity: Minor
Found in app/models/gringotts/attempt_validator.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language