Sign upLogin

conveyal/modeify

View on GitHub
Star
client/components/conveyal/transitive.js/master/lib/display/index.js

Summary

Maintainability
F
4 days
Test Coverage

Function Display has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function Display(transitive) {
  this.transitive = transitive;
  var el = this.el = transitive.el;
  this.width = el.clientWidth;
  this.height = el.clientHeight;
Severity: Major
Found in client/components/conveyal/transitive.js/master/lib/display/index.js - About 2 hrs to fix

    Function getDomains has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getDomains(display, height, width, bounds, options) {
  var xmin = bounds[0][0],
    xmax = bounds[1][0];
  var ymin = bounds[0][1],
    ymax = bounds[1][1];
    Severity: Major
    Found in client/components/conveyal/transitive.js/master/lib/display/index.js - About 2 hrs to fix

      File index.js has 253 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      var d3 = require('d3');
var debug = require('debug')('transitive:display');
var each = require('each');

var Legend = require('./legend');
      Severity: Minor
      Found in client/components/conveyal/transitive.js/master/lib/display/index.js - About 2 hrs to fix

        Function Display has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        function Display(transitive) {
  this.transitive = transitive;
  var el = this.el = transitive.el;
  this.width = el.clientWidth;
  this.height = el.clientHeight;
        Severity: Minor
        Found in client/components/conveyal/transitive.js/master/lib/display/index.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getMargins has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function getMargins(options) {
  var margins = {
    left: 0,
    right: 0,
    top: 0,
        Severity: Minor
        Found in client/components/conveyal/transitive.js/master/lib/display/index.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getDomains has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        function getDomains(display, height, width, bounds, options) {
  var xmin = bounds[0][0],
    xmax = bounds[1][0];
  var ymin = bounds[0][1],
    ymax = bounds[1][1];
        Severity: Minor
        Found in client/components/conveyal/transitive.js/master/lib/display/index.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getDomains has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function getDomains(display, height, width, bounds, options) {
        Severity: Minor
        Found in client/components/conveyal/transitive.js/master/lib/display/index.js - About 35 mins to fix

          Function updateActiveZoomFactors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          Display.prototype.updateActiveZoomFactors = function(scale) {
  var updated = false;
  for (var i = 0; i < this.zoomFactors.length; i++) {
    var min = this.zoomFactors[i].minScale;
    var max = (i < this.zoomFactors.length - 1) ?
          Severity: Minor
          Found in client/components/conveyal/transitive.js/master/lib/display/index.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            } else { // x-axis limiting
    padding = paddingFactor * xRange;
    dispX1 = xmin - padding;
    dispX2 = xmax + padding;
    dispXRange = xRange + 2 * padding;
          Severity: Major
          Found in client/components/conveyal/transitive.js/master/lib/display/index.js and 1 other location - About 1 day to fix
          client/components/conveyal/transitive.js/master/lib/display/index.js on lines 308..323

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 252.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            if (usableDisplayAspect > graphAspect) { // y-axis is limiting
    padding = paddingFactor * yRange;
    dispY1 = ymin - padding;
    dispY2 = ymax + padding;
    dispYRange = yRange + 2 * padding;
          Severity: Major
          Found in client/components/conveyal/transitive.js/master/lib/display/index.js and 1 other location - About 1 day to fix
          client/components/conveyal/transitive.js/master/lib/display/index.js on lines 323..339

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 252.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status