Sign upLogin

conveyal/modeify

View on GitHub
Star
client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js

Summary

Maintainability
F
3 days
Test Coverage

Function PointLabel has 176 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var PointLabel = augment(Label, function(base) {

  this.constructor = function(parent) {

    base.constructor.call(this, parent);
Severity: Major
Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 7 hrs to fix

    Function PointLabel has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
    Open

    var PointLabel = augment(Label, function(base) {

  this.constructor = function(parent) {

    base.constructor.call(this, parent);
    Severity: Minor
    Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getBBox has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.getBBox = function() {

    if (this.orientation === 'E') {
      return {
        x: this.labelAnchor.x,
    Severity: Major
    Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 2 hrs to fix

      Function setOrientation has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        this.setOrientation = function(orientation) {
    this.orientation = orientation;

    var markerBBox = this.parent.getMarkerBBox();
    if (!markerBBox) return;
      Severity: Minor
      Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 2 hrs to fix

        Avoid too many return statements within this function.
        Open

              return {
        x: this.labelAnchor.x,
        y: this.labelAnchor.y - bboxSide,
        width: bboxSide,
        height: bboxSide
        Severity: Major
        Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return {
        x: this.labelAnchor.x - bboxSide,
        y: this.labelAnchor.y - bboxSide,
        width: bboxSide,
        height: bboxSide
          Severity: Major
          Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return {
        x: this.labelAnchor.x - bboxSide,
        y: this.labelAnchor.y,
        width: bboxSide,
        height: bboxSide
            Severity: Major
            Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return {
        x: this.labelAnchor.x,
        y: this.labelAnchor.y,
        width: bboxSide,
        height: bboxSide
              Severity: Major
              Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  this.intersects = function(obj) {
    if (obj instanceof Label) {
      // todo: handle label-label intersection for diagonally placed labels separately
      return this.intersectsBBox(obj.getBBox());
    } else if (obj.x && obj.y && obj.width && obj.height) {
                Severity: Major
                Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js and 1 other location - About 3 hrs to fix
                client/components/conveyal/transitive.js/master/lib/labeler/segmentlabel.js on lines 95..104

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (this.orientation === 'W') {
      return {
        x: this.labelAnchor.x - this.textWidth,
        y: this.labelAnchor.y - this.textHeight,
        width: this.textWidth,
                Severity: Major
                Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js and 1 other location - About 2 hrs to fix
                client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js on lines 145..152

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 79.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (this.orientation === 'N') {
      return {
        x: this.labelAnchor.x - this.textHeight,
        y: this.labelAnchor.y - this.textWidth,
        width: this.textHeight,
                Severity: Major
                Found in client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js and 1 other location - About 2 hrs to fix
                client/components/conveyal/transitive.js/master/lib/labeler/pointlabel.js on lines 136..143

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 79.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status