Sign upLogin

conveyal/modeify

View on GitHub
Star
client/components/conveyal/transitive.js/master/lib/point/index.js

Summary

Maintainability
D
1 day
Test Coverage

Function Point has 198 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Point = augment(Object, function() {

  this.constructor = function(data) {
    for (var key in data) {
      this[key] = data[key];
Severity: Major
Found in client/components/conveyal/transitive.js/master/lib/point/index.js - About 7 hrs to fix

    Function Point has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    var Point = augment(Object, function() {

  this.constructor = function(data) {
    for (var key in data) {
      this[key] = data[key];
    Severity: Minor
    Found in client/components/conveyal/transitive.js/master/lib/point/index.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructMergedMarker has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.constructMergedMarker = function(display) {

    var dataArray = this.getRenderDataArray();
    var xValues = [],
      yValues = [];
    Severity: Major
    Found in client/components/conveyal/transitive.js/master/lib/point/index.js - About 2 hrs to fix

      Function initMarkerData has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        this.initMarkerData = function(display) {

    if (this.getType() !== 'STOP' && this.getType() !== 'MULTI') return;

    this.mergedMarkerData = this.constructMergedMarker(display);
      Severity: Minor
      Found in client/components/conveyal/transitive.js/master/lib/point/index.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status