Sign upLogin

conveyal/modeify

View on GitHub
Star
client/components/conveyal/transitive.js/master/lib/util/index.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function lineIntersection has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

module.exports.lineIntersection = function(x1, y1, x2, y2, x3, y3, x4, y4) {
Severity: Major
Found in client/components/conveyal/transitive.js/master/lib/util/index.js - About 1 hr to fix

    Function rayIntersection has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    module.exports.rayIntersection = function(ax, ay, avx, avy, bx, by, bvx, bvy) {
    Severity: Major
    Found in client/components/conveyal/transitive.js/master/lib/util/index.js - About 1 hr to fix

      Function pointAlongArc has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      module.exports.pointAlongArc = function(x1, y1, x2, y2, r, theta, ccw, t) {
      Severity: Major
      Found in client/components/conveyal/transitive.js/master/lib/util/index.js - About 1 hr to fix

        Function ccw has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        module.exports.ccw = function(ax, ay, bx, by, cx, cy) {
        Severity: Minor
        Found in client/components/conveyal/transitive.js/master/lib/util/index.js - About 45 mins to fix

          Function angleFromThreePoints has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          module.exports.angleFromThreePoints = function(ax, ay, bx, by, cx, cy) {
          Severity: Minor
          Found in client/components/conveyal/transitive.js/master/lib/util/index.js - About 45 mins to fix

            Function ccwRaw has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            module.exports.ccwRaw = function(ax, ay, bx, by, cx, cy) {
            Severity: Minor
            Found in client/components/conveyal/transitive.js/master/lib/util/index.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  x: ((x1 * y2 - y1 * x2) * (x3 - x4) - (x1 - x2) * (x3 * y4 - y3 * x4)) / d,
              Severity: Minor
              Found in client/components/conveyal/transitive.js/master/lib/util/index.js and 1 other location - About 55 mins to fix
              client/components/conveyal/transitive.js/master/lib/util/index.js on lines 104..104

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  y: ((x1 * y2 - y1 * x2) * (y3 - y4) - (y1 - y2) * (x3 * y4 - y3 * x4)) / d,
              Severity: Minor
              Found in client/components/conveyal/transitive.js/master/lib/util/index.js and 1 other location - About 55 mins to fix
              client/components/conveyal/transitive.js/master/lib/util/index.js on lines 103..103

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status