Sign upLogin

conveyal/modeify

View on GitHub
Star
client/help-me-choose-view/index.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function refresh has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Modal.prototype.refresh = function (e) {
  if (e) e.preventDefault()
  log('refreshing')

  primaryFilter = this.primaryFilter.value
Severity: Minor
Found in client/help-me-choose-view/index.js - About 1 hr to fix

    Function refresh has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    Modal.prototype.refresh = function (e) {
  if (e) e.preventDefault()
  log('refreshing')

  primaryFilter = this.primaryFilter.value
    Severity: Minor
    Found in client/help-me-choose-view/index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function rankRoutes has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function rankRoutes (routes, primary, secondary) {
  var primaryDomain = [d3.min(routes, primary), d3.max(routes, primary)]
  var secondaryDomain = [d3.min(routes, secondary), d3.max(routes, secondary)]

  var primaryScale = d3.scale.linear()
    Severity: Minor
    Found in client/help-me-choose-view/index.js - About 1 hr to fix

      Function renderRoute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      Modal.prototype.renderRoute = function (data) {
  data.calories = data.calories ? parseInt(data.calories, 10).toLocaleString() + ' cals' : 'None'
  data.cost = data.cost ? '$' + data.cost.toFixed(2) : 'Free'
  data.emissions = data.emissions ? parseInt(data.emissions, 10) : 'None'
  data.walkDistance = data.walkDistance ? data.walkDistance + ' mi' : 'None'
      Severity: Minor
      Found in client/help-me-choose-view/index.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status