Sign upLogin

conveyal/modeify

View on GitHub
Star
lib/plan/profile-filter.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function filterExcessiveTransitOptions has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function filterExcessiveTransitOptions (opts) {
  var comparator = function (a, b) {
    return b.score - a.score
  }
  var bikeToTransitOpts = new PriorityQueue(comparator)
Severity: Minor
Found in lib/plan/profile-filter.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

        return true
    Severity: Major
    Found in lib/plan/profile-filter.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return true
      Severity: Major
      Found in lib/plan/profile-filter.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          while (bikeshareToTransitOpts.size() > 0 && count < max - 1) {
    opts.push(bikeshareToTransitOpts.deq())
    count++
  }
        Severity: Minor
        Found in lib/plan/profile-filter.js and 1 other location - About 55 mins to fix
        lib/plan/profile-filter.js on lines 150..153

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          while (bikeToTransitOpts.size() > 0 && count < max - 1) {
    opts.push(bikeToTransitOpts.deq())
    count++
  }
        Severity: Minor
        Found in lib/plan/profile-filter.js and 1 other location - About 55 mins to fix
        lib/plan/profile-filter.js on lines 155..158

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (option.egress && option.egress.length > 1) {
    option.egress = option.egress.filter(hasBicycleRent)
  }
        Severity: Major
        Found in lib/plan/profile-filter.js and 2 other locations - About 45 mins to fix
        lib/plan/profile-filter.js on lines 215..217
        lib/plan/r5-to-otp.js on lines 85..87

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          if (option.access && option.access.length > 1) {
    option.access = option.access.filter(hasBicycleRent)
  }
        Severity: Major
        Found in lib/plan/profile-filter.js and 2 other locations - About 45 mins to fix
        lib/plan/profile-filter.js on lines 218..220
        lib/plan/r5-to-otp.js on lines 85..87

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status