conveyal/transitive.js

View on GitHub

Showing 105 of 165 total issues

Function reset has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  reset() {
    for (const i in types) {
      const type = types[i]
      this[type] = Object.assign({}, styles[type] || {})
      for (const key in this[type]) {
Severity: Minor
Found in lib/styler/styler.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function coordAlongRefEdge has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  coordAlongRefEdge(targetDistance, coords, refCoordinates = coords) {
    // our current location along the edge (in world units)
    let currentLocation = 0
    for (let i = 1; i < refCoordinates.length; i++) {
      const distanceToNextCoord = refCoordinates[i].len
Severity: Minor
Found in lib/graph/edge.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return '#f00'
Severity: Major
Found in lib/styler/styles.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          if (a.point && a.point.getType() === 'STOP') return -1
    Severity: Major
    Found in lib/graph/graph.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            if (segment.type.startsWith('SCOOTER')) return 4
      Severity: Major
      Found in lib/styler/styles.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return '#f5a729'
        Severity: Major
        Found in lib/styler/styles.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                if (segment.mode === 3) return 6 // Buses
          Severity: Major
          Found in lib/styler/styles.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return {
                    height: bboxSide,
                    width: bboxSide,
                    x: this.labelAnchor.x - bboxSide,
                    y: this.labelAnchor.y - bboxSide
            Severity: Major
            Found in lib/labeler/pointlabel.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return {
                      height: bboxSide,
                      width: bboxSide,
                      x: this.labelAnchor.x,
                      y: this.labelAnchor.y - bboxSide
              Severity: Major
              Found in lib/labeler/pointlabel.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return {
                        height: bboxSide,
                        width: bboxSide,
                        x: this.labelAnchor.x,
                        y: this.labelAnchor.y
                Severity: Major
                Found in lib/labeler/pointlabel.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return {
                          height: bboxSide,
                          width: bboxSide,
                          x: this.labelAnchor.x - bboxSide,
                          y: this.labelAnchor.y
                  Severity: Major
                  Found in lib/labeler/pointlabel.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return '#86cdf9'
                    Severity: Major
                    Found in lib/styler/styles.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            if (b.point && b.point.getType() === 'STOP') return 1
                      Severity: Major
                      Found in lib/graph/graph.js - About 30 mins to fix

                        Function stroke-dasharray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            function (display, data) {
                              const segment = data
                              if (segment.type === 'WALK') return '0, 8'
                              if (
                                segment.type.startsWith('BICYCLE') ||
                        Severity: Minor
                        Found in lib/styler/styles.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function addPattern has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                          addPattern(pattern, fromIndex, toIndex) {
                            // Initialize this segment's 'points' array to include the stops in the
                            // provided pattern between the specified from and to indices, inclusive.
                            // Only do this if the points array is empty or if the the length of the
                            // segment being added exceeds that of the one currently stored.
                        Severity: Minor
                        Found in lib/core/pathsegment.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function offsetAlignment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                          offsetAlignment(alignmentId, offset) {
                            // If from/to alignment IDs match, set respective offset.
                            if (this.graphEdge.getFromAlignmentId() === alignmentId) {
                              this.setFromOffset(
                                isOutwardVector(this.graphEdge.fromVector) ? offset : -offset
                        Severity: Minor
                        Found in lib/renderer/renderededge.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function background has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            function (display, segment) {
                              if (segment.type === 'TRANSIT') {
                                if (segment.patterns) {
                                  if (patternIsDcCirculatorBusRoute(segment.patterns[0])) return '#f00'
                                  return segment.patterns[0].route.getColor()
                        Severity: Minor
                        Found in lib/styler/styles.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function invertColor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        export function invertColor(hex, bw = true) {
                          if (hex.indexOf('#') === 0) {
                            hex = hex.slice(1)
                          }
                          // convert 3-digit hex to 6-digits.
                        Severity: Minor
                        Found in lib/util/color.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function color has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            function (display, segment) {
                              if (segment.type === 'TRANSIT') {
                                if (segment.patterns) {
                                  if (patternIsDcCirculatorBusRoute(segment.patterns[0])) return '#fff'
                                  return segment.patterns[0].route.getTextColor()
                        Severity: Minor
                        Found in lib/styler/styles.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function stroke-width has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            function (display, segment, index, utils) {
                              if (segment.type === 'WALK') return 6
                              if (segment.type.startsWith('BICYCLE')) return 4
                              if (segment.type.startsWith('CAR')) return 4
                              if (segment.type.startsWith('MICROMOBILITY')) return 4
                        Severity: Minor
                        Found in lib/styler/styles.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language