conveyal/transitive.js

View on GitHub
lib/labeler/labeler.js

Summary

Maintainability
D
2 days
Test Coverage

File labeler.js has 327 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { forEach } from 'lodash'
import measureText from 'measure-text'
import d3 from 'd3' // TODO: replace w/ other quadtree library

import { getFontSizeWithUnit } from '../util'
Severity: Minor
Found in lib/labeler/labeler.js - About 3 hrs to fix

    Function addSegmentsToQuadtree has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      addSegmentsToQuadtree() {
        forEach(this.transitive.renderSegments, (segment) => {
          if (segment.getType() !== 'TRANSIT') return
    
          let lw = this.transitive.style.compute(
    Severity: Major
    Found in lib/labeler/labeler.js - About 2 hrs to fix

      Function placePointLabels has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        placePointLabels() {
          const styler = this.transitive.styler
      
          const placedLabels = []
          // var labeledPoints = []
      Severity: Minor
      Found in lib/labeler/labeler.js - About 2 hrs to fix

        Function placeSegmentLabels has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          placeSegmentLabels() {
            this.placedLabelKeys = []
            const placedLabels = []
        
            // collect the bus RenderSegments
        Severity: Minor
        Found in lib/labeler/labeler.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

                if (
                  p &&
                  p[0] >= minX &&
                  p[0] < maxX &&
                  p[1] >= minY &&
          Severity: Major
          Found in lib/labeler/labeler.js - About 1 hr to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      this.addBBoxToQuadtree({
                        height: lw,
                        width: Math.abs(x1 - x2),
                        x: Math.min(x1, x2),
                        y: y
            Severity: Major
            Found in lib/labeler/labeler.js and 2 other locations - About 55 mins to fix
            lib/labeler/labeler.js on lines 117..122
            lib/labeler/labeler.js on lines 128..133

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      this.addBBoxToQuadtree({
                        height: lw,
                        width: Math.abs(x1 - x2),
                        x: Math.min(x1, x2),
                        y: y
            Severity: Major
            Found in lib/labeler/labeler.js and 2 other locations - About 55 mins to fix
            lib/labeler/labeler.js on lines 91..96
            lib/labeler/labeler.js on lines 128..133

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      this.addBBoxToQuadtree({
                        height: Math.abs(y1 - y2),
                        width: lw,
                        x: x,
                        y: Math.min(y1, y2)
            Severity: Major
            Found in lib/labeler/labeler.js and 2 other locations - About 55 mins to fix
            lib/labeler/labeler.js on lines 80..85
            lib/labeler/labeler.js on lines 138..143

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      this.addBBoxToQuadtree({
                        height: Math.abs(y1 - y2),
                        width: lw,
                        x: x,
                        y: Math.min(y1, y2)
            Severity: Major
            Found in lib/labeler/labeler.js and 2 other locations - About 55 mins to fix
            lib/labeler/labeler.js on lines 80..85
            lib/labeler/labeler.js on lines 107..112

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      this.addBBoxToQuadtree({
                        height: Math.abs(y1 - y2),
                        width: lw,
                        x: x,
                        y: Math.min(y1, y2)
            Severity: Major
            Found in lib/labeler/labeler.js and 2 other locations - About 55 mins to fix
            lib/labeler/labeler.js on lines 107..112
            lib/labeler/labeler.js on lines 138..143

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                      this.addBBoxToQuadtree({
                        height: lw,
                        width: Math.abs(x1 - x2),
                        x: Math.min(x1, x2),
                        y: y
            Severity: Major
            Found in lib/labeler/labeler.js and 2 other locations - About 55 mins to fix
            lib/labeler/labeler.js on lines 91..96
            lib/labeler/labeler.js on lines 117..122

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status