conveyal/transitive.js

View on GitHub
lib/point/point.js

Summary

Maintainability
C
1 day
Test Coverage

Point has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class Point {
  constructor(data) {
    for (const key in data) {
      this[key] = data[key]
    }
Severity: Minor
Found in lib/point/point.js - About 3 hrs to fix

    Function constructMergedMarker has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      constructMergedMarker(display) {
        const dataArray = this.getRenderDataArray()
        const xValues = []
        const yValues = []
        dataArray.forEach(function (data) {
    Severity: Major
    Found in lib/point/point.js - About 2 hrs to fix

      Function initMarkerData has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        initMarkerData(display) {
          if (this.getType() !== 'STOP' && this.getType() !== 'MULTI') return
      
          this.mergedMarkerData = this.constructMergedMarker(display)
      
      
      Severity: Minor
      Found in lib/point/point.js - About 1 hr to fix

        Function constructMergedMarker has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          constructMergedMarker(display) {
            const dataArray = this.getRenderDataArray()
            const xValues = []
            const yValues = []
            dataArray.forEach(function (data) {
        Severity: Minor
        Found in lib/point/point.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status