Sign upLogin

coopdevs/timeoverflow

View on GitHub
Star

Showing 7 of 14 total issues

Method global_activity has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def global_activity
    members = current_organization.members
    @active_members = members.active

    @total_hours = num_movements = 0
Severity: Minor
Found in app/controllers/statistics_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method global_activity has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def global_activity
    members = current_organization.members
    @active_members = members.active

    @total_hours = num_movements = 0
Severity: Minor
Found in app/controllers/statistics_controller.rb - About 1 hr to fix

    Method create has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    authorize User

    email = user_params[:email]
    @user = User.find_or_initialize_by(email: email) do |u|
    Severity: Minor
    Found in app/controllers/users_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_account has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def find_account(id, type, organization_id, errors, direction)
    Severity: Minor
    Found in app/services/transfer_importer.rb - About 35 mins to fix

      Method ensure_url has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def ensure_url
    return if web.blank? || URI.parse(web).is_a?(URI::HTTP)
  rescue
    errors.add(:web, :url_format_invalid)
  else
      Severity: Minor
      Found in app/models/organization.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def update
    @user = User.find(params[:id])
    authorize @user unless @user == current_user

    if @user.update(user_params)
      Severity: Minor
      Found in app/controllers/users_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method find_account has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def find_account(id, type, organization_id, errors, direction)
      acc = if type.downcase == 'organization'
              Organization.find(organization_id).account
            else
              Member.find_by(member_uid: id, organization_id: organization_id)&.account
      Severity: Minor
      Found in app/services/transfer_importer.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language