Sign upLogin

cozy-labs/cozy-desktop

View on GitHub
Star
core/remote/change.js

Summary

Maintainability
F
4 days
Test Coverage

Function sortForMove has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

const sortForMove = (move, b, moveFirst) => {
  if (isMove(b)) {
    if (isDescendant(move) && isDescendant(b)) {
      if (areParentChild(deletedPath(move), deletedPath(b))) return moveFirst
      if (areParentChild(deletedPath(b), deletedPath(move))) return -moveFirst
Severity: Minor
Found in core/remote/change.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sortForMove has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const sortForMove = (move, b, moveFirst) => {
  if (isMove(b)) {
    if (isDescendant(move) && isDescendant(b)) {
      if (areParentChild(deletedPath(move), deletedPath(b))) return moveFirst
      if (areParentChild(deletedPath(b), deletedPath(move))) return -moveFirst
Severity: Minor
Found in core/remote/change.js - About 1 hr to fix

    Function sortForAdd has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    const sortForAdd = (add, b, addFirst) => {
  if (isRestore(b) || isAdd(b)) {
    if (areParentChild(createdPath(add), createdPath(b))) return addFirst
    if (areParentChild(createdPath(b), createdPath(add))) return -addFirst
    Severity: Minor
    Found in core/remote/change.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sortChanges has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    const sortChanges = (a, b) => {
  if (isDelete(a) || isTrash(a)) return sortForDelete(a, b, aFirst)
  if (isDelete(b) || isTrash(b)) return sortForDelete(b, a, bFirst)

  if (isMove(a)) return sortForMove(a, b, aFirst)
    Severity: Minor
    Found in core/remote/change.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sortForDelete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    const sortForDelete = (del, b, delFirst) => {
  if (isDelete(b) || isTrash(b)) {
    if (lower(deletedPath(del), deletedPath(b))) return delFirst
    if (lower(deletedPath(b), deletedPath(del))) return -delFirst
    Severity: Minor
    Found in core/remote/change.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        if (lower(createdPath(b), createdPath(move))) return -moveFirst
    Severity: Major
    Found in core/remote/change.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          if (lower(createdPath(move), createdPath(b))) return moveFirst
      Severity: Major
      Found in core/remote/change.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return 0
        Severity: Major
        Found in core/remote/change.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return moveFirst
          Severity: Major
          Found in core/remote/change.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return delFirst
            Severity: Major
            Found in core/remote/change.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return -descFirst
              Severity: Major
              Found in core/remote/change.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return 0
                Severity: Major
                Found in core/remote/change.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                    return 0
                  Severity: Major
                  Found in core/remote/change.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        if (areParentChild(createdPath(move), createdPath(b))) return moveFirst
                    Severity: Major
                    Found in core/remote/change.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          if (areParentChild(createdPath(b), createdPath(move))) return -moveFirst
                      Severity: Major
                      Found in core/remote/change.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              if (lower(deletedPath(move), deletedPath(b))) return moveFirst
                        Severity: Major
                        Found in core/remote/change.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              if (areParentChild(deletedPath(b), deletedPath(move))) return moveFirst
                          Severity: Major
                          Found in core/remote/change.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                if (areParentChild(deletedPath(move), createdPath(b))) return -moveFirst
                            Severity: Major
                            Found in core/remote/change.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                if (areEqual(deletedId(desc), createdId(b))) return descFirst
                              Severity: Major
                              Found in core/remote/change.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                  if (isRestore(b) || isAdd(b)) return sortForAdd(b, a, bFirst)
                                Severity: Major
                                Found in core/remote/change.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                        return sortForDescendant(b, move, -moveFirst)
                                  Severity: Major
                                  Found in core/remote/change.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                        if (areEqual(deletedId(b), createdId(move))) return -moveFirst
                                    Severity: Major
                                    Found in core/remote/change.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                        if (areEqual(deletedId(b), createdId(desc))) return descFirst
                                      Severity: Major
                                      Found in core/remote/change.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                          return addFirst
                                        Severity: Major
                                        Found in core/remote/change.js - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                            if (lower(ignoredPath(b), ignoredPath(a))) return bFirst
                                          Severity: Major
                                          Found in core/remote/change.js - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                return 0
                                            Severity: Major
                                            Found in core/remote/change.js - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                    return sortForDescendant(move, b, moveFirst)
                                              Severity: Major
                                              Found in core/remote/change.js - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                      return 0
                                                Severity: Major
                                                Found in core/remote/change.js - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                    if (isRestore(a) || isAdd(a)) return sortForAdd(a, b, aFirst)
                                                  Severity: Major
                                                  Found in core/remote/change.js - About 30 mins to fix

                                                    Avoid too many return statements within this function.
                                                    Open

                                                          if (lower(deletedPath(b), deletedPath(move))) return -moveFirst
                                                    Severity: Major
                                                    Found in core/remote/change.js - About 30 mins to fix

                                                      Avoid too many return statements within this function.
                                                      Open

                                                          if (areParentChild(deletedPath(move), deletedPath(b))) return -moveFirst
                                                      Severity: Major
                                                      Found in core/remote/change.js - About 30 mins to fix

                                                        Avoid too many return statements within this function.
                                                        Open

                                                          if (lower(ignoredPath(a), ignoredPath(b))) return aFirst
                                                        Severity: Major
                                                        Found in core/remote/change.js - About 30 mins to fix

                                                          Avoid too many return statements within this function.
                                                          Open

                                                              if (areParentChild(deletedPath(b), createdPath(move))) return moveFirst
                                                          Severity: Major
                                                          Found in core/remote/change.js - About 30 mins to fix

                                                            Avoid too many return statements within this function.
                                                            Open

                                                                if (areParentChild(createdPath(move), deletedPath(b))) return moveFirst
                                                            Severity: Major
                                                            Found in core/remote/change.js - About 30 mins to fix

                                                              Avoid too many return statements within this function.
                                                              Open

                                                                  if (areParentChild(createdPath(b), deletedPath(move))) return -moveFirst
                                                              Severity: Major
                                                              Found in core/remote/change.js - About 30 mins to fix

                                                                Avoid too many return statements within this function.
                                                                Open

                                                                    if (areEqual(deletedId(move), createdId(b))) return moveFirst
                                                                Severity: Major
                                                                Found in core/remote/change.js - About 30 mins to fix

                                                                  Function sortForDescendant has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                                                  Open

                                                                  const sortForDescendant = (desc, b, descFirst) => {
  if (areParentChild(deletedPath(desc), createdPath(b))) return descFirst
  if (areParentChild(deletedPath(b), createdPath(desc))) return -descFirst

  if (areParentChild(createdPath(b), deletedPath(desc))) return descFirst
                                                                  Severity: Minor
                                                                  Found in core/remote/change.js - About 25 mins to fix

                                                                  Cognitive Complexity

                                                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                                  A method's cognitive complexity is based on a few simple rules:

                                                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                                  • Code is considered more complex for each "break in the linear flow of the code"
                                                                  • Code is considered more complex when "flow breaking structures are nested"

                                                                  Further reading

                                                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                                                  Open

                                                                  function deleted(
  doc /*: SavedMetadata */
) /*: RemoteFileDeletion | RemoteDirDeletion */ {
  if (metadata.isFile(doc)) {
    return {
                                                                  Severity: Major
                                                                  Found in core/remote/change.js and 1 other location - About 1 hr to fix
                                                                  core/remote/change.js on lines 219..235

                                                                  Duplicated Code

                                                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                  Tuning

                                                                  This issue has a mass of 71.

                                                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                  Refactorings

                                                                  Further Reading

                                                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                                                  Open

                                                                  function updated(
  doc /*: Metadata */
) /*: RemoteFileUpdate | RemoteDirUpdate */ {
  if (metadata.isFile(doc)) {
    return {
                                                                  Severity: Major
                                                                  Found in core/remote/change.js and 1 other location - About 1 hr to fix
                                                                  core/remote/change.js on lines 194..210

                                                                  Duplicated Code

                                                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                  Tuning

                                                                  This issue has a mass of 71.

                                                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                  Refactorings

                                                                  Further Reading

                                                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                                                  Open

                                                                  const isFileMove = (a /*: RemoteChange */) /*: boolean %checks */ =>
  a.type === 'FileMove' || (isDescendant(a) && a.doc.docType === metadata.FILE)
                                                                  Severity: Minor
                                                                  Found in core/remote/change.js and 1 other location - About 50 mins to fix
                                                                  core/remote/change.js on lines 310..311

                                                                  Duplicated Code

                                                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                  Tuning

                                                                  This issue has a mass of 52.

                                                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                  Refactorings

                                                                  Further Reading

                                                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                                                  Open

                                                                  const isFolderMove = (a /*: RemoteChange */) /*: boolean %checks */ =>
  a.type === 'DirMove' || (isDescendant(a) && a.doc.docType === metadata.FOLDER)
                                                                  Severity: Minor
                                                                  Found in core/remote/change.js and 1 other location - About 50 mins to fix
                                                                  core/remote/change.js on lines 308..309

                                                                  Duplicated Code

                                                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                  Tuning

                                                                  This issue has a mass of 52.

                                                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                  Refactorings

                                                                  Further Reading

                                                                  There are no issues that match your filters.

                                                                  Category
                                                                  Status