Sign upLogin

cozy-labs/cozy-desktop

View on GitHub
Star
core/remote/index.js

Summary

Maintainability
D
2 days
Test Coverage

File index.js has 353 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/** The remote side read/write interface.
 *
 * @module core/remote
 * @flow
 */
Severity: Minor
Found in core/remote/index.js - About 4 hrs to fix

    Remote has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Remote /*:: implements Reader, Writer */ {
  /*::
  name: SideName
  other: Reader & Writer
  config: Config
    Severity: Minor
    Found in core/remote/index.js - About 2 hrs to fix

      Function moveAsync has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async moveAsync /*::<T: Metadata|SavedMetadata> */(
    newMetadata /*: T */,
    oldMetadata /*: T */
  ) /*: Promise<void> */ {
    const remoteId = oldMetadata.remote._id
      Severity: Minor
      Found in core/remote/index.js - About 1 hr to fix

        Function overwriteFileAsync has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async overwriteFileAsync(
    doc /*: SavedMetadata */,
    onProgress /*: ?ProgressCallback */
  ) /*: Promise<void> */ {
    const { path } = doc
        Severity: Minor
        Found in core/remote/index.js - About 1 hr to fix

          Function addFileAsync has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            async addFileAsync(
    doc /*: SavedMetadata */,
    onProgress /*: ?ProgressCallback */
  ) /*: Promise<void> */ {
    const { path } = doc
          Severity: Minor
          Found in core/remote/index.js - About 1 hr to fix

            Function addFolderAsync has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              async addFolderAsync(doc /*: SavedMetadata */) /*: Promise<void> */ {
    const { path } = doc
    log.info({ path }, 'Creating folder...')

    const [parentPath, name] = dirAndName(doc.path)
            Severity: Minor
            Found in core/remote/index.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function moveAsync has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              async moveAsync /*::<T: Metadata|SavedMetadata> */(
    newMetadata /*: T */,
    oldMetadata /*: T */
  ) /*: Promise<void> */ {
    const remoteId = oldMetadata.remote._id
            Severity: Minor
            Found in core/remote/index.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              async resolveConflict /*::<T: Metadata|SavedMetadata> */(
    newMetadata /*: T & { remote: MetadataRemoteInfo } */
  ) /*: Promise<?T> */ {
    const conflict = metadata.createConflictingDoc(newMetadata)
            Severity: Major
            Found in core/remote/index.js and 1 other location - About 2 hrs to fix
            core/local/index.js on lines 502..514

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 85.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    try {
          stream = await this.other.createReadStreamAsync(doc)
        } catch (err) {
          if (err.code === 'ENOENT') {
            log.warn({ path }, 'Local file does not exist anymore.')
            Severity: Major
            Found in core/remote/index.js and 1 other location - About 1 hr to fix
            core/remote/index.js on lines 194..205

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    try {
          stream = await this.other.createReadStreamAsync(doc)
        } catch (err) {
          if (err.code === 'ENOENT') {
            log.warn({ path }, 'Local file does not exist anymore.')
            Severity: Major
            Found in core/remote/index.js and 1 other location - About 1 hr to fix
            core/remote/index.js on lines 236..247

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status