Sign upLogin

cozy-labs/cozy-desktop

View on GitHub
Star
core/sync/errors.js

Summary

Maintainability
C
1 day
Test Coverage

Function retryDelay has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const retryDelay = (err /*: RemoteError|SyncError */) /*: number */ => {
  // Speed up tests
  if (process.env.NODE_ENV === 'test') return 500

  if (err instanceof remoteErrors.RemoteError) {
Severity: Minor
Found in core/sync/errors.js - About 1 hr to fix

    Function retry has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    const retry = async (
  cause /*: {| err: RemoteError |} | {| err: SyncError, change: Change |} */,
  sync /*: Sync */
) => {
  log.debug(cause, 'retrying after blocking error')
    Severity: Minor
    Found in core/sync/errors.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function retryDelay has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    const retryDelay = (err /*: RemoteError|SyncError */) /*: number */ => {
  // Speed up tests
  if (process.env.NODE_ENV === 'test') return 500

  if (err instanceof remoteErrors.RemoteError) {
    Severity: Minor
    Found in core/sync/errors.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function wrapError has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    const wrapError = (
  err /*: ErrnoError|FetchError|Error */,
  sideName /*: SideName */,
  { doc } /*: { doc: SavedMetadata } */ = {}
) => {
    Severity: Minor
    Found in core/sync/errors.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return new SyncError({
      sideName,
      err: remoteErrors.wrapError(err, doc),
      doc
    })
    Severity: Major
    Found in core/sync/errors.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return new SyncError({ sideName, err, code: EXCLUDED_DIR_CODE, doc })
      Severity: Major
      Found in core/sync/errors.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return new SyncError({ sideName, err, doc })
        Severity: Major
        Found in core/sync/errors.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          module.exports = {
  EXCLUDED_DIR_CODE,
  INCOMPATIBLE_DOC_CODE,
  MISSING_PERMISSIONS_CODE,
  NO_DISK_SPACE_CODE,
          Severity: Major
          Found in core/sync/errors.js and 1 other location - About 2 hrs to fix
          core/utils/logger.js on lines 209..224

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            constructor(parent /*: SavedMetadata */) {
    super('Parent move was not successfully synchronized')

    if (Error.captureStackTrace) {
      Error.captureStackTrace(this, UnsyncedParentMoveError)
          Severity: Minor
          Found in core/sync/errors.js and 1 other location - About 55 mins to fix
          core/remote/errors.js on lines 102..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status