Sign upLogin

cph/activerecord-insert_many

View on GitHub
Star

Showing 3 of 3 total issues

Method insert_many_sql has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def insert_many_sql(fixtures, table_name, options={})
      returning = options[:returning]

      columns = schema_cache.columns_hash(table_name)
Severity: Minor
Found in lib/activerecord/insert_many.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method insert_many_sql has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def insert_many_sql(fixtures, table_name, options={})
      returning = options[:returning]

      columns = schema_cache.columns_hash(table_name)
Severity: Minor
Found in lib/activerecord/insert_many.rb - About 1 hr to fix

    Method insert_many has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def insert_many(fixtures, table_name=self.table_name, options={})
      returning = options[:returning]
      if returning
        raise ArgumentError, "To use :returning, you must be using Postgres" unless supports_returning?
      elsif supports_returning?
    Severity: Minor
    Found in lib/activerecord/insert_many.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language