Sign upLogin

crafatar/crafatar

View on GitHub
Star
lib/networking.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function get_from_options has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exp.get_from_options = function(rid, url, options, callback) {
  var is_session_req = config.server.sessions_rate_limit && url.startsWith(session_url);

  // This is to prevent being blocked by CloudFront for exceeding the rate limit
  if (is_session_req && req_count() >= config.server.sessions_rate_limit) {
Severity: Major
Found in lib/networking.js - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

      if (is_session_req && req_count() >= config.server.sessions_rate_limit) {
    var e = new Error("Skipped, rate limit exceeded");
    e.name = "HTTP";
    e.code = "RATELIMIT";
    Severity: Critical
    Found in lib/networking.js - About 2 hrs to fix

      Function get_from_options has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      exp.get_from_options = function(rid, url, options, callback) {
  var is_session_req = config.server.sessions_rate_limit && url.startsWith(session_url);

  // This is to prevent being blocked by CloudFront for exceeding the rate limit
  if (is_session_req && req_count() >= config.server.sessions_rate_limit) {
      Severity: Minor
      Found in lib/networking.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status