Function loadGistModal
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
Gister.prototype.loadGistModal = function() {
var frame = document.querySelector('#gistModal');
var modalBody = '<p>What is the gist URL? All text in the editor will be '
+'replaced with the gist content.</p>'
+'<input style="width: 100%;" id="gist-url" type="text">';
- Create a ticketCreate a ticket
Do not use 'new' for side effects. Open
new bsn.Button(e.target, 'reset');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Disallow new For Side Effects (no-new)
The goal of using new
with a constructor is typically to create an object of a particular type and store that object in a variable, such as:
var person = new Person();
It's less common to use new
and not store the result, such as:
new Person();
In this case, the created object is thrown away because its reference isn't stored anywhere, and in many cases, this means that the constructor should be replaced with a function that doesn't require new
to be used.
Rule Details
This rule is aimed at maintaining consistency and convention by disallowing constructor calls using the new
keyword that do not assign the resulting object to a variable.
Examples of incorrect code for this rule:
/*eslint no-new: "error"*/
new Thing();
Examples of correct code for this rule:
/*eslint no-new: "error"*/
var thing = new Thing();
Thing();
Source: http://eslint.org/docs/rules/
Do not use 'new' for side effects. Open
new bsn.Button(e.target, 'reset');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Disallow new For Side Effects (no-new)
The goal of using new
with a constructor is typically to create an object of a particular type and store that object in a variable, such as:
var person = new Person();
It's less common to use new
and not store the result, such as:
new Person();
In this case, the created object is thrown away because its reference isn't stored anywhere, and in many cases, this means that the constructor should be replaced with a function that doesn't require new
to be used.
Rule Details
This rule is aimed at maintaining consistency and convention by disallowing constructor calls using the new
keyword that do not assign the resulting object to a variable.
Examples of incorrect code for this rule:
/*eslint no-new: "error"*/
new Thing();
Examples of correct code for this rule:
/*eslint no-new: "error"*/
var thing = new Thing();
Thing();
Source: http://eslint.org/docs/rules/
The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype. Open
for (var fileName in files) {
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Require Guarding for-in (guard-for-in)
Looping over objects with a for in
loop will include properties that are inherited through the prototype chain. This behavior can lead to unexpected items in your for loop.
for (key in foo) {
doSomething(key);
}
Note that simply checking foo.hasOwnProperty(key)
is likely to cause an error in some cases; see [no-prototype-builtins](no-prototype-builtins.md).
Rule Details
This rule is aimed at preventing unexpected behavior that could arise from using a for in
loop without filtering the results in the loop. As such, it will warn when for in
loops do not filter their results with an if
statement.
Examples of incorrect code for this rule:
/*eslint guard-for-in: "error"*/
for (key in foo) {
doSomething(key);
}
Examples of correct code for this rule:
/*eslint guard-for-in: "error"*/
for (key in foo) {
if (Object.prototype.hasOwnProperty.call(foo, key)) {
doSomething(key);
}
if ({}.hasOwnProperty.call(foo, key)) {
doSomething(key);
}
}
Related Rules
- [no-prototype-builtins](no-prototype-builtins.md)
Further Reading
Do not use 'new' for side effects. Open
new bsn.Button(e.target, 'reset');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Disallow new For Side Effects (no-new)
The goal of using new
with a constructor is typically to create an object of a particular type and store that object in a variable, such as:
var person = new Person();
It's less common to use new
and not store the result, such as:
new Person();
In this case, the created object is thrown away because its reference isn't stored anywhere, and in many cases, this means that the constructor should be replaced with a function that doesn't require new
to be used.
Rule Details
This rule is aimed at maintaining consistency and convention by disallowing constructor calls using the new
keyword that do not assign the resulting object to a variable.
Examples of incorrect code for this rule:
/*eslint no-new: "error"*/
new Thing();
Examples of correct code for this rule:
/*eslint no-new: "error"*/
var thing = new Thing();
Thing();
Source: http://eslint.org/docs/rules/
Do not use 'new' for side effects. Open
new bsn.Button(e.target, 'loading');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Disallow new For Side Effects (no-new)
The goal of using new
with a constructor is typically to create an object of a particular type and store that object in a variable, such as:
var person = new Person();
It's less common to use new
and not store the result, such as:
new Person();
In this case, the created object is thrown away because its reference isn't stored anywhere, and in many cases, this means that the constructor should be replaced with a function that doesn't require new
to be used.
Rule Details
This rule is aimed at maintaining consistency and convention by disallowing constructor calls using the new
keyword that do not assign the resulting object to a variable.
Examples of incorrect code for this rule:
/*eslint no-new: "error"*/
new Thing();
Examples of correct code for this rule:
/*eslint no-new: "error"*/
var thing = new Thing();
Thing();
Source: http://eslint.org/docs/rules/