Sign upLogin

crobinson42/express-api-routes

View on GitHub
Star

Showing 2 of 6 total issues

Function makeControllerRoutes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    makeControllerRoutes () {
      // this will go through all of the controllers and assign a route/path and
      // handler for each controller method. ie: /{controllerFileName}/{methodName}
      // @NOTE it DOES NOT assign a route/path if the method has already been
      // declared in the routes config with a path THAT CONTAINS policies.
Severity: Minor
Found in lib/Routes.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeConfigRoutes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    makeConfigRoutes () {
      const routes = this.config.routes
      // iterate the routes config and make sure all controller/method & policies exist
      for (var path in routes) {
        if (!this.config.controllers[routes[path].controller]) {
Severity: Minor
Found in lib/Routes.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language