Sign upLogin

crossfilter/universe

View on GitHub
Star
src/aggregation.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function convertAggregatorString has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function convertAggregatorString(keyString) {
  // var obj = {} // obj is defined but not used

  // 1. unwrap top parentheses
  // 2. detect arrays
Severity: Minor
Found in src/aggregation.js - About 1 hr to fix

    Function unwrapParensAndCommas has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function unwrapParensAndCommas(str) {
    str = str.replace(' ', '')
    return (
      '"' +
      str.replace(outerParens, function(p, pr) {
    Severity: Minor
    Found in src/aggregation.js - About 1 hr to fix

      Function makeSubAggregationFunction has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function makeSubAggregationFunction(obj) {
  // If its an object, either unwrap all of the properties as an
  // array of keyValues, or unwrap the first keyValue set as an object
  obj = _.isObject(obj) ? extractKeyValOrArray(obj) : obj
      Severity: Minor
      Found in src/aggregation.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function makeSubAggregationFunction has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function makeSubAggregationFunction(obj) {
  // If its an object, either unwrap all of the properties as an
  // array of keyValues, or unwrap the first keyValue set as an object
  obj = _.isObject(obj) ? extractKeyValOrArray(obj) : obj
      Severity: Minor
      Found in src/aggregation.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

          return []
        Severity: Major
        Found in src/aggregation.js - About 30 mins to fix

          Function makeValueAccessor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function makeValueAccessor(obj) {
  if (typeof obj === 'string') {
    if (isStringSyntax(obj)) {
      obj = convertAggregatorString(obj)
    } else {
          Severity: Minor
          Found in src/aggregation.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status