Sign upLogin

crowbar/crowbar-core

View on GitHub
Star

Showing 1,006 of 6,062 total issues

Consider simplifying this complex logical expression.
Open

          if (hlSpotsEnabled || options.get('spotColor') ||
            (options.get('minSpotColor') || options.get('maxSpotColor') &&
              (yvalues[yvallast] === this.miny || yvalues[yvallast] === this.maxy))) {
            canvasWidth -= Math.ceil(spotRadius);
          }
Severity: Major
Found in crowbar_framework/vendor/assets/javascripts/jquery/sparkline.js - About 40 mins to fix

Consider simplifying this complex logical expression.
Open

            if (out.initialPreview !== undefined && out.initialPreview.length > 0) {
                self.hasInitData = true;
                content = out.initialPreview || [];
                config = out.initialPreviewConfig || [];
                tags = out.initialPreviewThumbTags || [];
Severity: Major
Found in crowbar_framework/vendor/assets/javascripts/bootstrap/fileinput.js - About 40 mins to fix

Consider simplifying this complex logical expression.
Open

            unless candidates.empty?
              match = candidates.find { |b| b =~ /^wwn-/ } ||
                candidates.find { |b| b =~ /^scsi-[a-zA-Z]/ } ||
                candidates.find { |b| b =~ /^scsi-[^1]/ } ||
                candidates.find { |b| b =~ /^scsi-/ } ||
Severity: Major
Found in chef/cookbooks/barclamp/libraries/barclamp_library.rb - About 40 mins to fix

Consider simplifying this complex logical expression.
Open

      unless bootdisks.empty?
        # SLE11 SP3 generates so-called "MSFT compatibility links"
        # that start with scsi-1. Skip those, as those are less
        # reusable than the normal links.
        # Note: this find construct should match the code in
Severity: Major
Found in chef/cookbooks/provisioner/recipes/bootdisk.rb - About 40 mins to fix

Consider simplifying this complex logical expression.
Open

    if meta
      # For some disk (e.g. virtio without serial number on SLE12)
      # meta["disks"] is empty. In that case we can't get a "more unique"
      # name than "vdX"
      return "/dev/#{device}" unless meta["disks"]
Severity: Major
Found in crowbar_framework/app/models/node.rb - About 40 mins to fix

Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    add: function( elem, types, handler, data, selector ) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/jquery.js - About 35 mins to fix

Function updateLines has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    function updateLines(from, to, newText, selFrom, selTo) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/codemirror/codemirror.js - About 35 mins to fix

Function superMatcher has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        superMatcher = function( seed, context, xml, results, outermost ) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/jquery.js - About 35 mins to fix

Function updateLinesNoUndo has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    function updateLinesNoUndo(from, to, newText, selFrom, selTo) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/codemirror/codemirror.js - About 35 mins to fix

Function augmentWidthOrHeight has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function augmentWidthOrHeight( elem, name, extra, isBorderBox, styles ) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/jquery.js - About 35 mins to fix

Function on has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    on: function( types, selector, data, fn, /*INTERNAL*/ one ) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/jquery.js - About 35 mins to fix

Function parseJS has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  function parseJS(state, style, type, content, stream) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/codemirror/javascript.js - About 35 mins to fix

Function remove has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    remove: function( elem, types, handler, selector, mappedTypes ) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/jquery.js - About 35 mins to fix

Function Tween has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function Tween( elem, options, prop, end, easing ) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/jquery.js - About 35 mins to fix

Function CHILD has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        "CHILD": function( type, what, argument, first, last ) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/jquery.js - About 35 mins to fix

Function condense has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function condense( unmatched, map, filter, context, xml ) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/jquery.js - About 35 mins to fix

Function _dialogDatepicker has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    _dialogDatepicker: function(input, date, onSelect, settings, pos) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/ui.js - About 35 mins to fix

Function switchClass has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    switchClass: function( remove, add, speed, easing, callback) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/ui.js - About 35 mins to fix

Function init has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      init: function (el, values, options, width, height) {
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/sparkline.js - About 35 mins to fix

Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

jQuery.event.add = function( elem, types, handler, data, selector ){
Severity: Minor
Found in crowbar_framework/vendor/assets/javascripts/jquery/migrate.js - About 35 mins to fix
Severity
Category
Status
Source
Language