csballz/koala-puree

View on GitHub
lib/models.js

Summary

Maintainability
F
1 wk
Test Coverage

File models.js has 521 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * This module creates a wrapper around the orientose orm
 *
 * @module lib/models
 * @link OrientoseModelPlugin
Severity: Major
Found in lib/models.js - About 1 day to fix

    Function OrientoseModelPlugin has 199 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function OrientoseModelPlugin() {
        /**
         * @class OrientoseModelPlugin
         */
        var obj = {
    Severity: Major
    Found in lib/models.js - About 7 hrs to fix

      Function buildschema has 173 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          buildschema(parent) {
              var self = this;
              parent = parent || Schema.V;
              var schema = new parent(self._props, {
                  className: this._name
      Severity: Major
      Found in lib/models.js - About 6 hrs to fix

        Function OrientoseModelPlugin has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function OrientoseModelPlugin() {
            /**
             * @class OrientoseModelPlugin
             */
            var obj = {
        Severity: Minor
        Found in lib/models.js - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setupModel has 89 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                setup: function * setupModel(next) {
        
                    var app = this;
                    debug(`beginning model middleware`);
                    var dburl;
        Severity: Major
        Found in lib/models.js - About 3 hrs to fix

          Function buildschema has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

              buildschema(parent) {
                  var self = this;
                  parent = parent || Schema.V;
                  var schema = new parent(self._props, {
                      className: this._name
          Severity: Minor
          Found in lib/models.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _reverseLocate has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                                      schema.static("findBy"+name, function _reverseLocate(id){
                                          if ( id._id ) {
                                              id = id._id;
                                          }
                                          var self = this;
          Severity: Minor
          Found in lib/models.js - About 1 hr to fix

            Function _getRelation has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                                        schema.method(methodName, function _getRelation(){
                                            var self = this;
                                            var query = this._orientose()
                                                    ._db
                                                    .select()
            Severity: Minor
            Found in lib/models.js - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                          if (!app._config.db || !app._config.db.url) {
                              let config = app._config.db || {};
                              let username = config.username || "root";
                              let password = config.password || "root";
                              let host = config.host || "localhost";
              Severity: Critical
              Found in lib/models.js - About 1 hr to fix

                Function seed has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        seed: function(app) {
                            return new Promise(function(resolve, reject){
                                glob(require("path").resolve(app._basePath, "db/seed/*.js"), function(er, files) {
                                    if (er) {
                                        return reject(er);
                Severity: Minor
                Found in lib/models.js - About 1 hr to fix

                  Consider simplifying this complex logical expression.
                  Open

                                          if ( "link" in rel || "in" in rel || "out" in rel || "both" in rel ) {
                                              var cond = rel.link || rel.in || rel.out || rel.both;
                                              var reverseCond;
                                              if ( "link" !== rel.linkType ) {
                                                  if ( rel.in ) {
                  Severity: Major
                  Found in lib/models.js - About 1 hr to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                    if ( one ) {
                                                        query.limit(1);
                                                    }
                    Severity: Major
                    Found in lib/models.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                              if ( one ) {
                                                                  return Promise.resolve(model._createDocument(m[0]));
                                                              }
                      Severity: Major
                      Found in lib/models.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                                if ( one ) {
                                                                    debug("creating just one?", m[0]);
                                                                    return model._createDocument(m[0]);
                                                                }
                        Severity: Major
                        Found in lib/models.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                              if ( fn ) {
                                                                  p = p.then(fn);
                                                              }
                          Severity: Major
                          Found in lib/models.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                            if ( id._id ) {
                                                                id = id._id;
                                                            }
                            Severity: Major
                            Found in lib/models.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                          if ( "link" !== rel.linkType ) {
                                                              if ( rel.in ) {
                                                                  reverseCond = "out";
                                                              } else if ( rel.out ) {
                                                                  reverseCond = "in";
                              Severity: Major
                              Found in lib/models.js - About 45 mins to fix

                                Function genModel has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                function genModel(file, remove, orientose, app, builders, parentSchema) {
                                Severity: Minor
                                Found in lib/models.js - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                                      if ( fn ) {
                                                                          p = p.then(fn);
                                                                      }
                                  Severity: Major
                                  Found in lib/models.js - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                                    if ( one ) {
                                                                        query.limit(1);
                                                                    }
                                    Severity: Major
                                    Found in lib/models.js - About 45 mins to fix

                                      Strings must use doublequote.
                                      Open

                                                  debug(`beginning model middleware`);
                                      Severity: Minor
                                      Found in lib/models.js by eslint

                                      enforce the consistent use of either backticks, double, or single quotes (quotes)

                                      JavaScript allows you to define strings in one of three ways: double quotes, single quotes, and backticks (as of ECMAScript 6). For example:

                                      /*eslint-env es6*/
                                      
                                      var double = "double";
                                      var single = 'single';
                                      var backtick = `backtick`;    // ES6 only

                                      Each of these lines creates a string and, in some cases, can be used interchangeably. The choice of how to define strings in a codebase is a stylistic one outside of template literals (which allow embedded of expressions to be interpreted).

                                      Many codebases require strings to be defined in a consistent manner.

                                      Rule Details

                                      This rule enforces the consistent use of either backticks, double, or single quotes.

                                      Options

                                      This rule has two options, a string option and an object option.

                                      String option:

                                      • "double" (default) requires the use of double quotes wherever possible
                                      • "single" requires the use of single quotes wherever possible
                                      • "backtick" requires the use of backticks wherever possible

                                      Object option:

                                      • "avoidEscape": true allows strings to use single-quotes or double-quotes so long as the string contains a quote that would have to be escaped otherwise
                                      • "allowTemplateLiterals": true allows strings to use backticks

                                      Deprecated: The object property avoid-escape is deprecated; please use the object property avoidEscape instead.

                                      double

                                      Examples of incorrect code for this rule with the default "double" option:

                                      /*eslint quotes: ["error", "double"]*/
                                      
                                      var single = 'single';
                                      var unescaped = 'a string containing "double" quotes';

                                      Examples of correct code for this rule with the default "double" option:

                                      /*eslint quotes: ["error", "double"]*/
                                      /*eslint-env es6*/
                                      
                                      var double = "double";
                                      var backtick = `back\ntick`;  // backticks are allowed due to newline
                                      var backtick = tag`backtick`; // backticks are allowed due to tag

                                      single

                                      Examples of incorrect code for this rule with the "single" option:

                                      /*eslint quotes: ["error", "single"]*/
                                      
                                      var double = "double";
                                      var unescaped = "a string containing 'single' quotes";

                                      Examples of correct code for this rule with the "single" option:

                                      /*eslint quotes: ["error", "single"]*/
                                      /*eslint-env es6*/
                                      
                                      var single = 'single';
                                      var backtick = `back${x}tick`; // backticks are allowed due to substitution

                                      backticks

                                      Examples of incorrect code for this rule with the "backtick" option:

                                      /*eslint quotes: ["error", "backtick"]*/
                                      
                                      var single = 'single';
                                      var double = "double";
                                      var unescaped = 'a string containing `backticks`';

                                      Examples of correct code for this rule with the "backtick" option:

                                      /*eslint quotes: ["error", "backtick"]*/
                                      /*eslint-env es6*/
                                      
                                      var backtick = `backtick`;

                                      avoidEscape

                                      Examples of additional correct code for this rule with the "double", { "avoidEscape": true } options:

                                      /*eslint quotes: ["error", "double", { "avoidEscape": true }]*/
                                      
                                      var single = 'a string containing "double" quotes';

                                      Examples of additional correct code for this rule with the "single", { "avoidEscape": true } options:

                                      /*eslint quotes: ["error", "single", { "avoidEscape": true }]*/
                                      
                                      var double = "a string containing 'single' quotes";

                                      Examples of additional correct code for this rule with the "backtick", { "avoidEscape": true } options:

                                      /*eslint quotes: ["error", "backtick", { "avoidEscape": true }]*/
                                      
                                      var double = "a string containing `backtick` quotes"

                                      allowTemplateLiterals

                                      Examples of additional correct code for this rule with the "double", { "allowTemplateLiterals": true } options:

                                      /*eslint quotes: ["error", "double", { "allowTemplateLiterals": true }]*/
                                      
                                      var double = "double";
                                      var double = `double`;

                                      Examples of additional correct code for this rule with the "single", { "allowTemplateLiterals": true } options:

                                      /*eslint quotes: ["error", "single", { "allowTemplateLiterals": true }]*/
                                      
                                      var single = 'single';
                                      var single = `single`;

                                      When Not To Use It

                                      If you do not need consistency in your string styles, you can safely disable this rule. Source: http://eslint.org/docs/rules/

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                      ModelBuilder.prototype.embedded = function(name, fn) {
                                          this._later = this._later || [];
                                          this._later.push(function(schemas) {
                                              if (require("util").isFunction(fn)) {
                                                  this.attr(name, fn(schemas));
                                      Severity: Major
                                      Found in lib/models.js and 1 other location - About 3 hrs to fix
                                      lib/models.js on lines 297..306

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 114.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                      ModelBuilder.prototype.embeddedlist = function(name, fn) {
                                          this._later = this._later || [];
                                          this._later.push(function(schemas) {
                                              if (require("util").isFunction(fn)) {
                                                  this.attr(name, fn(schemas));
                                      Severity: Major
                                      Found in lib/models.js and 1 other location - About 3 hrs to fix
                                      lib/models.js on lines 308..317

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 114.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                                      "limit where order let".split(" ").forEach(function(name){
                                                                          newQuery[name] = function(){
                                                                              debug(this.query);
                                                                              this.query[name].apply(this.query, arguments);
                                                                              return this;
                                      Severity: Major
                                      Found in lib/models.js and 1 other location - About 2 hrs to fix
                                      lib/models.js on lines 178..184

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 79.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                                      "limit where order let".split(" ").forEach(function(name){
                                                                          newQuery[name] = function(){
                                                                              debug(this.query);
                                                                              this.query[name].apply(this.query, arguments);
                                                                              return this;
                                      Severity: Major
                                      Found in lib/models.js and 1 other location - About 2 hrs to fix
                                      lib/models.js on lines 140..146

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 79.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                          for (var i = 0; i < builders.length; i++) {
                                                              schemas[builders[i]._name] = builders[i]._schema;
                                                          }
                                      Severity: Minor
                                      Found in lib/models.js and 1 other location - About 55 mins to fix
                                      lib/models.js on lines 451..453

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 54.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                              for (var i = 0; i < builders.length; i++) {
                                                                  schemas[builders[i]._name] = builders[i]._schema;
                                                              }
                                      Severity: Minor
                                      Found in lib/models.js and 1 other location - About 55 mins to fix
                                      lib/models.js on lines 427..429

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 54.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                      if (app._app.env !== "production") {
                                                          dbname = `${dbname}-${app._app.env}`;
                                                      }
                                      Severity: Minor
                                      Found in lib/models.js and 1 other location - About 35 mins to fix
                                      lib/models.js on lines 502..504

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 47.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  if (app._app.env !== "production") {
                                                      dbname = `${dbname}-${app._app.env}`;
                                                  }
                                      Severity: Minor
                                      Found in lib/models.js and 1 other location - About 35 mins to fix
                                      lib/models.js on lines 389..391

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 47.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status