ct2034/dockeROS

View on GitHub

Showing 2 of 68 total issues

Function __init__ has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def __init__(self, roscommand, config, dockerfile=None):
        """
            Initilizes the commands with the rospkg configuration and roscommands allowed in this context
            Args:
                roscommand: any of suppoorted roscommands (rosrun/roslaunch)
Severity: Minor
Found in src/dockeros/image.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function replaceDockerfile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def replaceDockerfile(self, in_fname, dockerfile_fname):
        if os.path.exists(dockerfile_fname):
            if os.path.samefile(in_fname, dockerfile_fname):
                logging.warning("Using Dockerfile without replacing (%s)"%dockerfile_fname)
                return
Severity: Minor
Found in src/dockeros/image.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language