cyclejs/cycle-core

View on GitHub

Showing 112 of 188 total issues

Function setupZapping has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupZapping(
  [graph, zapSpeed]: [dagre.graphlib.Graph, ZapSpeed],
): Diagram {
  const registry: ZapRegistry = new ZapRegistry();
  const sourceNodes: Array<string> = graph['sources']();
Severity: Minor
Found in devtool/src/graphSerializer.ts - About 1 hr to fix

    Function nodes has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function nodes(
      timestamp: number,
      speed: number,
      height: number,
      nodeCount: number
    Severity: Minor
    Found in time/example/index.ts - About 1 hr to fix

      Function makeIsolateSink has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function makeIsolateSink<T extends VNode>(
        namespace: Array<Scope>
      ): IsolateSink<T> {
        return (sink, scope) => {
          if (scope === ':root') {
      Severity: Minor
      Found in dom/src/isolate.ts - About 1 hr to fix

        Function makeCallOnHistory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function makeCallOnHistory(history: History) {
          return function call(input: Narrow<HistoryInput>): void {
            if (input.type === 'push') {
              history.push({...input});
            }
        Severity: Minor
        Found in history/src/createHistory$.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function renderCommonNode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function renderCommonNode(node: StreamGraphNode, zaps: Array<Zap>): VNode {
          const index = zaps.map(zap => zap.id).indexOf(node.id);
          const zap = index === -1 ? null : zaps[index];
        
          return svg.g([
        Severity: Minor
        Found in devtool/src/panel/graph/view.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          public get(
            path: Array<T>,
            mkDefaultElement?: () => Payload,
            max?: number
          ): Payload | undefined {
        Severity: Minor
        Found in dom/src/SymbolTree.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function removeElement has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public removeElement(element: Element, namespace?: Array<Scope>): void {
            if (namespace !== undefined) {
              this.virtualListeners.delete(namespace);
            }
            const toRemove: Array<[string, Element]> = [];
        Severity: Minor
        Found in dom/src/EventDelegator.ts - About 1 hr to fix

          Function processEvent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function processEvent() {
              if (paused) {
                return;
              }
          
          
          Severity: Minor
          Found in time/src/time-driver.ts - About 1 hr to fix

            Function animationFrames has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              return function animationFrames(): Stream<Frame> {
                const frame = {
                  time: 0,
                  delta: 16,
                  normalizedDelta: 1,
            Severity: Minor
            Found in time/src/animation-frames.ts - About 1 hr to fix

              Function BmiCalculator has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function BmiCalculator(sources: Sources): Sinks {
                const WeightSlider = isolate(LabeledSlider) as typeof LabeledSlider;
                const HeightSlider = isolate(LabeledSlider) as typeof LabeledSlider;
              
                const weightProps$ = xs.of({
              Severity: Minor
              Found in examples/intermediate/bmi-typescript/src/BmiCalculator.ts - About 1 hr to fix

                Function main has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function main(sources: {DOM: DOMSource, HTTP: HTTPSource}) {
                  const getRandomUser$ = sources.DOM.select('.get-random').events('click')
                    .map(() => {
                      const randomNum = Math.round(Math.random() * 9) + 1;
                      return {
                Severity: Minor
                Found in examples/basic/http-random-user/src/index.ts - About 1 hr to fix

                  Function processEvent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function processEvent(args: any) {
                    const {scheduler, done, currentTime, setTime, timeToRunTo} = args;
                    const nextEvent = scheduler.peek();
                    const outOfTime = nextEvent && timeToRunTo && nextEvent.time >= timeToRunTo;
                  
                  
                  Severity: Minor
                  Found in time/src/run-virtually.ts - About 1 hr to fix

                    Function makeDebounce has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function makeDebounce(createOperator: () => OperatorArgs<any>) {
                      const {schedule, currentTime} = createOperator();
                    
                      return function debounce(debounceInterval: number) {
                        return function debounceOperator<T>(inputStream: Stream<T>): Stream<T> {
                    Severity: Minor
                    Found in time/src/debounce.ts - About 1 hr to fix

                      Function model has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      function model(action$) {
                        const initReducer$ = xs.of(function initReducer(prevState) {
                          if (typeof prevState === 'undefined') {
                            return {id: 0, removable: false, children: []}
                          } else {
                      Severity: Minor
                      Found in examples/advanced/nested-folders/src/Folder.js - About 1 hr to fix

                        Function makeThrottle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function makeThrottle(createOperator: () => OperatorArgs<any>) {
                          const {schedule, currentTime} = createOperator();
                        
                          return function throttle(period: number) {
                            return function throttleOperator<T>(inputStream: Stream<T>): Stream<T> {
                        Severity: Minor
                        Found in time/src/throttle.ts - About 1 hr to fix

                          Function start has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                start(listener) {
                                  let lastValue: any = null;
                                  let emittedLastValue = true;
                                  const frame$ = xs.fromObservable(source.animationFrames());
                          
                          
                          Severity: Minor
                          Found in time/src/throttle-animation.ts - About 1 hr to fix

                            Function showReport has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function showReport(status) {
                              var headerShown = false;
                              for (var package in status) {
                                if (status.hasOwnProperty(package) && status[package].increment > 0) {
                                  if (!headerShown) {
                            Severity: Minor
                            Found in .scripts/check-release.js - About 1 hr to fix

                              Function matchObject has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function matchObject(matcher: object, obj: object): boolean {
                                const keys = Object.keys(matcher);
                                const n = keys.length;
                                for (let i = 0; i < n; i++) {
                                  const k = keys[i];
                              Severity: Minor
                              Found in dom/src/fromEvent.ts - About 55 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function makeDebounceListener has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                              Open

                              function makeDebounceListener<T>(
                                schedule: any,
                                currentTime: () => number,
                                debounceInterval: number,
                                listener: any,
                              Severity: Minor
                              Found in time/src/debounce.ts - About 55 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function bubble has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                                private bubble(
                                  eventType: string,
                                  elm: Element,
                                  rootElement: Element | undefined,
                                  event: CycleDOMEvent,
                              Severity: Minor
                              Found in dom/src/EventDelegator.ts - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language