Sign upLogin

cynek/rfsms

View on GitHub
Star

Showing 5 of 5 total issues

Consider simplifying this complex logical expression.
Open

        unless @smsid = elements[:smsid] and
              @datetime = elements[:datetime] and @datetime =~ DATEREGEXP and
              @text = elements[:text] and
              @source = elements[:source] and
              @all_col = elements[:all_col] and
Severity: Critical
Found in lib/rfsms.rb - About 2 hrs to fix

    Method initialize has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(body, &validate)
      body_e = Nori.parse(body, :nokogiri)
      p body_e if $DEBUG

      elements = body_e[:data]
    Severity: Minor
    Found in lib/rfsms.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method report has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def report(options = {})
      message = message_header
      unless options.empty?
        start, stop = options[:start].strftime(DATEFORMAT), options[:stop].strftime(DATEFORMAT)
        if start =~ DATEREGEXP and stop =~ DATEREGEXP
    Severity: Minor
    Found in lib/rfsms.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method send has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def send(text, phones, datetime = nil, source = nil, onlydelivery = false)
    Severity: Minor
    Found in lib/rfsms.rb - About 35 mins to fix

      Method send has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def send(text, phones, datetime = nil, source = nil, onlydelivery = false)
      message = message_header
      message << "<text>#{text}</text>"

      case phones
      Severity: Minor
      Found in lib/rfsms.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language