d3yii2/d3files

View on GitHub
assets/js/d3files-preview.js

Summary

Maintainability
D
1 day
Test Coverage

File d3files-preview.js has 434 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*jslint browser */
/*globals D3PDF, console, jQuery, D3FilesPreviewJsVars*/
/*global D3PDF, console, jQuery, D3FilesPreviewJsVars*/
/*jshint esversion: 6 */
/**
Severity: Minor
Found in assets/js/d3files-preview.js - About 6 hrs to fix

    Function preview has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            preview: function (e) {
                this.handlers.modalMessages.empty();
                this.handlers.modalContent.empty();
                try {
                    let m = this.getAttachmentData(e);
    Severity: Minor
    Found in assets/js/d3files-preview.js - About 1 hr to fix

      Function D3FilesPreview has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $.D3FilesPreview = function () {
              this.gridSelector = '#ThGridViewTable tbody';
              this.handlers = {
                  previewButton: $('.d3files-preview-widget-load'),
                  previewDropdown: $('.d3files-preview-dropdown'),
      Severity: Minor
      Found in assets/js/d3files-preview.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                getNextData: function(modelId, arr) {
                    let nextModelId = this.getArrNextValue(arr, modelId);
                    if (! nextModelId) {
                        return null;
                    }
        Severity: Major
        Found in assets/js/d3files-preview.js and 1 other location - About 1 hr to fix
        assets/js/d3files-preview.js on lines 405..412

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                getPrevData: function(modelId, arr) {
                    let prevModelId = this.getArrPrevValue(arr, modelId);
                    if (! prevModelId) {
                        return null;
                    }
        Severity: Major
        Found in assets/js/d3files-preview.js and 1 other location - About 1 hr to fix
        assets/js/d3files-preview.js on lines 397..404

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (pms) {
                            this.setLoadButtonAttrs(this.handlers.prevButton, pms);
                            this.handlers.prevButton.show();
                        }
        Severity: Minor
        Found in assets/js/d3files-preview.js and 1 other location - About 30 mins to fix
        assets/js/d3files-preview.js on lines 419..422

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (nms) {
                            this.setLoadButtonAttrs(this.handlers.nextButton, nms);
                            this.handlers.nextButton.show();
                        }
        Severity: Minor
        Found in assets/js/d3files-preview.js and 1 other location - About 30 mins to fix
        assets/js/d3files-preview.js on lines 424..427

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status