Sign upLogin

daikiueda/xlsx2json

View on GitHub
Star

Showing 3 of 3 total issues

Function convertXlsxToJson has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function convertXlsxToJson(pathToXlsx, options = {}) {
    return new Promise((resolve, reject) => {
        let workbook,
            sheets;
Severity: Minor
Found in lib/xlsx2json.js - About 2 hrs to fix

    Function xlsx2json has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function xlsx2json(pathToXlsx, options, callback) {
    return new Promise((resolve, reject) => {
        const argTypes = Array.from(arguments).slice(0, 3)
            .map(value => typeof value).join(',');
        let errorMessage;
    Severity: Minor
    Found in lib/xlsx2json.js - About 1 hr to fix

      Function pickSheetsFromWorkbook has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function pickSheetsFromWorkbook(workbook, cond) {
    switch (typeof cond) {
        case 'string':
            if (workbook.Sheets[cond]) {
                return [workbook.Sheets[cond]];
      Severity: Minor
      Found in lib/xlsx2json.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language