Sign upLogin

daitokai/daitokaiet

View on GitHub
Star

Showing 139 of 155 total issues

Method update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def update
      respond_to do |format|
        if current_user.update(users_params)
          format.html do
            if current_user.update_first_step!
Severity: Minor
Found in app/controllers/api/v1/users_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                                    if ( ofType ? node.nodeName.toLowerCase() === name : node.nodeType === 1 ) {
                                        return false;
                                    }
Severity: Major
Found in public/javascripts/jquery.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                    if ( ( ofType ? node.nodeName.toLowerCase() === name : node.nodeType === 1 ) && ++diff ) {
                                    // Cache the index of each encountered element
                                    if ( useCache ) {
                                        (node[ expando ] || (node[ expando ] = {}))[ type ] = [ dirruns, diff ];
                                    }
    Severity: Major
    Found in public/javascripts/jquery.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              while ( cur.indexOf( " " + clazz + " " ) >= 0 ) {
                            cur = cur.replace( " " + clazz + " ", " " );
                        }
      Severity: Major
      Found in public/javascripts/jquery.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if ( hasScripts ) {
                            jQuery.merge( scripts, getAll( node, "script" ) );
                        }
        Severity: Major
        Found in public/javascripts/jquery.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                              if ( typeof xhr.responseText === "string" ) {
                                        responses.text = xhr.responseText;
                                    }
          Severity: Major
          Found in public/javascripts/jquery.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if ( elem.id !== match[2] ) {
                            return rootjQuery.find( selector );
                        }
            Severity: Major
            Found in public/javascripts/jquery.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  for ( conv2 in converters ) {

                        // If conv2 outputs current
                        tmp = conv2.split( " " );
                        if ( tmp[ 1 ] === current ) {
              Severity: Major
              Found in public/javascripts/jquery.js - About 45 mins to fix

                Function setMatcher has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function setMatcher( preFilter, selector, matcher, postFilter, postFinder, postSelector ) {
                Severity: Minor
                Found in public/javascripts/jquery.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if ( name.indexOf("data-") === 0 ) {
                            name = jQuery.camelCase( name.slice(5) );

                            dataAttr( elem, name, data[ name ] );
                        }
                  Severity: Major
                  Found in public/javascripts/jquery.js - About 45 mins to fix

                    Consider simplifying this complex logical expression.
                    Open

                        if ( support.matchesSelector && documentIsHTML &&
        ( !rbuggyMatches || !rbuggyMatches.test( expr ) ) &&
        ( !rbuggyQSA     || !rbuggyQSA.test( expr ) ) ) {

        try {
                    Severity: Major
                    Found in public/javascripts/jquery.js - About 40 mins to fix

                      Consider simplifying this complex logical expression.
                      Open

                              if ( s.crossDomain == null ) {
            parts = rurl.exec( s.url.toLowerCase() );
            s.crossDomain = !!( parts &&
                ( parts[ 1 ] !== ajaxLocParts[ 1 ] || parts[ 2 ] !== ajaxLocParts[ 2 ] ||
                    ( parts[ 3 ] || ( parts[ 1 ] === "http:" ? "80" : "443" ) ) !==
                      Severity: Major
                      Found in public/javascripts/jquery.js - About 40 mins to fix

                        Consider simplifying this complex logical expression.
                        Open

                                    if ( matcher[ expando ] ) {
                // Find the next relative operator (if any) for proper handling
                j = ++i;
                for ( ; j < len; j++ ) {
                    if ( Expr.relative[ tokens[j].type ] ) {
                        Severity: Major
                        Found in public/javascripts/jquery.js - About 40 mins to fix

                          Consider simplifying this complex logical expression.
                          Open

                          if ( !jQuery.support.opacity ) {
    jQuery.cssHooks.opacity = {
        get: function( elem, computed ) {
            // IE uses filters for opacity
            return ropacity.test( (computed && elem.currentStyle ? elem.currentStyle.filter : elem.style.filter) || "" ) ?
                          Severity: Major
                          Found in public/javascripts/jquery.js - About 40 mins to fix

                            Consider simplifying this complex logical expression.
                            Open

                                if ( (!id || !cache[id] || (!pvt && !cache[id].data)) && data === undefined && typeof name === "string" ) {
        return;
    }
                            Severity: Major
                            Found in public/javascripts/jquery.js - About 40 mins to fix

                              Function CHILD has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      "CHILD": function( type, what, argument, first, last ) {
                              Severity: Minor
                              Found in public/javascripts/jquery.js - About 35 mins to fix

                                Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    add: function( elem, types, handler, data, selector ) {
                                Severity: Minor
                                Found in public/javascripts/jquery.js - About 35 mins to fix

                                  Function augmentWidthOrHeight has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  function augmentWidthOrHeight( elem, name, extra, isBorderBox, styles ) {
                                  Severity: Minor
                                  Found in public/javascripts/jquery.js - About 35 mins to fix

                                    Method liner_interpolate has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                      def self.liner_interpolate(start_x, start_y, end_x, end_y, x)
                                    Severity: Minor
                                    Found in app/models/record.rb - About 35 mins to fix

                                      Function remove has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                          remove: function( elem, types, handler, selector, mappedTypes ) {
                                      Severity: Minor
                                      Found in public/javascripts/jquery.js - About 35 mins to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language