Sign upLogin

daniellmb/AQUA

View on GitHub
Star
demos/angularjs/bower_components/todomvc-common/base.js

Summary

Maintainability
F
1 wk
Test Coverage

Function _ has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    var _ = (function (_) {
        _.defaults = function (object) {
            if (!object) {
                return object;
            }
Severity: Major
Found in demos/angularjs/bower_components/todomvc-common/base.js - About 3 hrs to fix

Function template has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        _.template = function(text, data, settings) {
            var render;
            settings = _.defaults({}, settings, _.templateSettings);

            // Combine delimiters into one regular expression via alternation.
Severity: Minor
Found in demos/angularjs/bower_components/todomvc-common/base.js - About 1 hr to fix

Function Learn has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function Learn(learnJSON, config) {
        if (!(this instanceof Learn)) {
            return new Learn(learnJSON, config);
        }
Severity: Minor
Found in demos/angularjs/bower_components/todomvc-common/base.js - About 1 hr to fix

Identical blocks of code found in 3 locations. Consider refactoring.
Open

(function () {
    'use strict';

    // Underscore's Template Module
    // Courtesy of underscorejs.org
Severity: Major
Found in demos/angularjs/bower_components/todomvc-common/base.js and 2 other locations - About 1 wk to fix
demos/requirejs/bower_components/todomvc-common/base.js on lines 1..209
demos/vanillajs/bower_components/todomvc-common/base.js on lines 1..209

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1569.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status