danielweinmann/unlock

View on GitHub

Showing 2 of 2 total issues

Method locale_country has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def locale_country(locale, allow_default_locales = false)
    country = locale.to_s.split('-')
    if allow_default_locales
      country = ["en", "GB"] if country == ["en"]
      country.size > 1 ? country[1].downcase : country[0]
Severity: Minor
Found in app/controllers/application_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_locale has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def set_locale
    if params[:locale]
      # Enforces locale with country
      raise I18n::InvalidLocale, params[:locale].to_sym unless locale_country(params[:locale], allow_default_locales?)
      I18n.locale = params[:locale]
Severity: Minor
Found in app/controllers/application_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language