Sign upLogin

danielwippermann/resol-vbus

View on GitHub
Star
src/tcp-connection-endpoint.js

Summary

Maintainability
F
3 days
Test Coverage

Function _onConnection has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
Open

    _onConnection(socket) {
        const _this = this;

        const connectionInfo = {
            socket,
Severity: Minor
Found in src/tcp-connection-endpoint.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _onConnection has 144 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _onConnection(socket) {
        const _this = this;

        const connectionInfo = {
            socket,
Severity: Major
Found in src/tcp-connection-endpoint.js - About 5 hrs to fix

    Function onData has 121 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            const onData = function(chunk) {
            if (phase < 1000) {
                let buffer;
                if (rxBuffer) {
                    buffer = Buffer.concat([ rxBuffer, chunk ]);
    Severity: Major
    Found in src/tcp-connection-endpoint.js - About 4 hrs to fix

      Function processLine has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      const processLine = function(line) {
                    let md;
                    if ((md = /^CONNECT (.*)$/.exec(line))) {
                        const viaTagString = md [1];
                        if (_this.verifyViaTag) {
      Severity: Major
      Found in src/tcp-connection-endpoint.js - About 2 hrs to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (channel) {
                                memo.push('*' + index + ':' + channel);
                            }
        Severity: Major
        Found in src/tcp-connection-endpoint.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              } else if ((md = /^CHANNEL (\d+)$/.exec(line))) {
                        const channelString = md [1];
                        const index = +channelString;
                        const channel = _this.channels [index];
                        if (_this.verifyChannel) {
          Severity: Major
          Found in src/tcp-connection-endpoint.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                            if (start < index) {
                                    const line = buffer.toString('utf8', start, index);
                                    start = index + 1;
                                    processLine(line);
                                    break;
            Severity: Major
            Found in src/tcp-connection-endpoint.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      if (_this.verifyViaTag) {
                            runAsync(() => _this.verifyViaTag(viaTagString, connectionInfo)).then(() => {
                                connectionInfo.viaTag = viaTagString;
                                callback(null, '+OK');
                            }, err => callback(err));
              Severity: Major
              Found in src/tcp-connection-endpoint.js and 1 other location - About 1 hr to fix
              src/tcp-connection-endpoint.js on lines 204..214

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      if (_this.verifyPassword) {
                            runAsync(() => _this.verifyPassword(passwordString, connectionInfo)).then(() => {
                                connectionInfo.password = passwordString;
                                callback(null, '+OK');
                            }, err => callback(err));
              Severity: Major
              Found in src/tcp-connection-endpoint.js and 1 other location - About 1 hr to fix
              src/tcp-connection-endpoint.js on lines 193..201

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status