danielwippermann/resol-vbus

View on GitHub
tools/configuration-importer/configuration-xml-deserializer.js

Summary

Maintainability
F
4 days
Test Coverage

File configuration-xml-deserializer.js has 469 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*! resol-vbus | Copyright (c) 2013-present, Daniel Wippermann | MIT license */

const _ = require('lodash');


Severity: Minor
Found in tools/configuration-importer/configuration-xml-deserializer.js - About 7 hrs to fix

    Function _deserializeType has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _deserializeType(parent, model) {
            this._filterProperties(parent, function(key, child) {
                switch (key) {
                case 'id':
                    model.id = this._getStringValue(child);
    Severity: Major
    Found in tools/configuration-importer/configuration-xml-deserializer.js - About 2 hrs to fix

      Function _deserializeMenuSystem has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _deserializeMenuSystem(parent, model) {
              this._filterProperties(parent, function(key, child) {
                  switch (key) {
                  case 'language':
                      model.languages.push(this._deserializeLanguage(child, new models.LanguageModel()));
      Severity: Major
      Found in tools/configuration-importer/configuration-xml-deserializer.js - About 2 hrs to fix

        Function _deserializeLine has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _deserializeLine(parent, model) {
                this._filterProperties(parent, function(key, child) {
                    switch (key) {
                    case 'id':
                        model.id = this._getStringValue(child);
        Severity: Minor
        Found in tools/configuration-importer/configuration-xml-deserializer.js - About 2 hrs to fix

          Function _deserializeValue has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _deserializeValue(parent, model) {
                  this._filterProperties(parent, function(key, child) {
                      switch (key) {
                      case 'id':
                          model.id = this._getStringValue(child);
          Severity: Minor
          Found in tools/configuration-importer/configuration-xml-deserializer.js - About 1 hr to fix

            Function _deserializeMask has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _deserializeMask(parent, model) {
                    this._filterProperties(parent, function(key, child) {
                        switch (key) {
                        case 'id':
                            model.id = this._getStringValue(child);
            Severity: Minor
            Found in tools/configuration-importer/configuration-xml-deserializer.js - About 1 hr to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  _deserializeTypeValueText(parent, model) {
                      this._filterProperties(parent, function(key, child) {
                          switch (key) {
                          case 'id':
                              model.id = this._getStringValue(child);
              tools/configuration-importer/configuration-xml-deserializer.js on lines 32..51
              tools/configuration-importer/configuration-xml-deserializer.js on lines 53..72

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  _deserializeLanguage(parent, model) {
                      this._filterProperties(parent, function(key, child) {
                          switch (key) {
                          case 'id':
                              model.id = this._getStringValue(child);
              tools/configuration-importer/configuration-xml-deserializer.js on lines 53..72
              tools/configuration-importer/configuration-xml-deserializer.js on lines 149..168

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  _deserializeTranslationGroup(parent, model) {
                      this._filterProperties(parent, function(key, child) {
                          switch (key) {
                          case 'from':
                              model.from = this._getStringValue(child);
              tools/configuration-importer/configuration-xml-deserializer.js on lines 32..51
              tools/configuration-importer/configuration-xml-deserializer.js on lines 149..168

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 135.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  _deserializeText(parent, model) {
                      this._filterProperties(parent, function(key, child) {
                          switch (key) {
                          case 'lang':
                              model.lang = this._getStringValue(child);
              tools/configuration-importer/configuration-xml-deserializer.js on lines 107..123

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 99.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  _deserializeTypeValue(parent, model) {
                      this._filterProperties(parent, function(key, child) {
                          switch (key) {
                          case 'id':
                              model.id = this._getStringValue(child);
              tools/configuration-importer/configuration-xml-deserializer.js on lines 14..30

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 99.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status