Sign upLogin

danielwippermann/resol-vbus

View on GitHub
Star
tools/configuration-importer/index.js

Summary

Maintainability
D
1 day
Test Coverage

Function mergeTypes has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const mergeTypes = function(menuSystem) {
    const typeById = _.reduce(menuSystem.types, (memo, type) => {
        memo [type.id] = type;
        return memo;
    }, {});
Severity: Major
Found in tools/configuration-importer/index.js - About 2 hrs to fix

    Function mergeType has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const mergeType = function(info, type) {
        if (type.base) {
            const baseType = typeById [type.base];
            if (baseType) {
                mergeType(info, baseType);
    Severity: Minor
    Found in tools/configuration-importer/index.js - About 1 hr to fix

      Function convertMenuXmlFile has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const convertMenuXmlFile = async function(inputFilename, outputFilename, convert) {
    inputFilename = path.resolve(__dirname, 'rpt-files', inputFilename);
    outputFilename = path.resolve(__dirname, '../../src/configuration-optimizers', outputFilename);

    console.log(outputFilename);
      Severity: Minor
      Found in tools/configuration-importer/index.js - About 1 hr to fix

        Function filterPrefsValues has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const filterPrefsValues = function(menuSystem) {
    const valueById = {};
    _.forEach(menuSystem.values, (value) => {
        valueById [value.id] = value;
    });
        Severity: Minor
        Found in tools/configuration-importer/index.js - About 1 hr to fix

          Function mergeTypes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          const mergeTypes = function(menuSystem) {
    const typeById = _.reduce(menuSystem.types, (memo, type) => {
        memo [type.id] = type;
        return memo;
    }, {});
          Severity: Minor
          Found in tools/configuration-importer/index.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function removeNamedValues has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const removeNamedValues = function(menuSystem, valueIds) {
    let valueIdPatterns;
    if (_.isArray(valueIds)) {
        valueIdPatterns = valueIds;
    } else {
          Severity: Minor
          Found in tools/configuration-importer/index.js - About 1 hr to fix

            Function filterPrefsValues has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            const filterPrefsValues = function(menuSystem) {
    const valueById = {};
    _.forEach(menuSystem.values, (value) => {
        valueById [value.id] = value;
    });
            Severity: Minor
            Found in tools/configuration-importer/index.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

            function promisify(fn) {
    return new Promise((resolve, reject) => {
        fn((err, result) => {
            if (err) {
                reject(err);
            Severity: Major
            Found in tools/configuration-importer/index.js and 2 other locations - About 1 hr to fix
            examples/em-simulator/main.js on lines 13..23
            tools/rsc-scheme-converter/main.js on lines 9..19

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                menuSystem.values = _.clone(menuSystem.values).sort((left, right) => {
        let result = right.priority - left.priority;
        if (result === 0) {
            result = left.index - right.index;
        }
            Severity: Major
            Found in tools/configuration-importer/index.js and 1 other location - About 1 hr to fix
            src/base-configuration-optimizer.js on lines 395..401

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status