Sign upLogin

darkwallet/darkwallet

View on GitHub
Star
src/js/dwutil/multisig.js

Summary

Maintainability
C
1 day
Test Coverage

File multisig.js has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

define(['darkwallet', 'bitcoinjs-lib', 'crypto-js', 'util/btc'], function(DarkWallet, Bitcoin, CryptoJS, BtcUtils) {

/**
Severity: Minor
Found in src/js/dwutil/multisig.js - About 2 hrs to fix

    Function importTransaction has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MultisigFund.prototype.importTransaction = function(serializedTx) {
    var self = this;
    // import transaction here
    var identity = DarkWallet.getIdentity();
    Severity: Minor
    Found in src/js/dwutil/multisig.js - About 1 hr to fix

      Function signTxForeign has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      MultisigFund.prototype.signTxForeign = function(foreignKey, spend) {
    var identity = DarkWallet.getIdentity();
    var multisig = this.multisig;

    var inputs = this.getValidInputs(spend.tx);
      Severity: Minor
      Found in src/js/dwutil/multisig.js - About 1 hr to fix

        Function detectParticipant has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        MultisigFund.prototype.detectParticipant = function(pubKeyBytes, i) {
    var identity = DarkWallet.getIdentity();

    // Ensure we check the compressed version for my address
    var myPubKey = Bitcoin.ECPubKey.fromBytes(pubKeyBytes, true);
        Severity: Minor
        Found in src/js/dwutil/multisig.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              for(var i=0; i<this.tasks.length; i++) {
        if (this.tasks[i].task === task) {
            return this.tasks[i];
        }
    }
          Severity: Major
          Found in src/js/dwutil/multisig.js and 1 other location - About 1 hr to fix
          src/js/model/multisig.js on lines 86..90

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status