Sign upLogin

datacite/bracco

View on GitHub
Star
app/controllers/repositories/show/prefixes/new.js

Summary

Maintainability
C
1 day
Test Coverage

Function submit has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    submit() {
      if (this.model['repository-prefix'].get('provider-prefix')) {
        let self = this;

        this.model['repository-prefix'].get('provider-prefix').then((m) => {
Severity: Minor
Found in app/controllers/repositories/show/prefixes/new.js - About 1 hr to fix

    Function searchPrefix has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      searchPrefix(query) {
    let self = this;
    let prefixes = [];

    this.prefixes_service
    Severity: Minor
    Found in app/controllers/repositories/show/prefixes/new.js - About 1 hr to fix

      Detected non-standard model lookups
      Open

      Severity: Minor
      Found in app/controllers/repositories/show/prefixes/new.js by watson

      Ember Data 2.0 now uses dasherized strings to lookup models instead of camel cased strings. For example:

      export default DS.Model.extend({
  postComments: DS.hasMany('post-comment', {async: true})
});

      To fix this, run ember watson:convert-ember-data-model-lookups.

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                } else {
            self.model['repository-prefix']
              .save()
              .then(function (repositoryPrefix) {
                self.set('disabled', true);
      Severity: Major
      Found in app/controllers/repositories/show/prefixes/new.js and 1 other location - About 3 hrs to fix
      app/controllers/repositories/show/prefixes/new.js on lines 70..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  m.save().then(function (value) {
              self.model['repository-prefix']
                .save()
                .then(function (repositoryPrefix) {
                  self.set('disabled', true);
      Severity: Major
      Found in app/controllers/repositories/show/prefixes/new.js and 1 other location - About 3 hrs to fix
      app/controllers/repositories/show/prefixes/new.js on lines 87..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status