Sign upLogin

datacite/bracco

View on GitHub
Star
app/helpers/doi-form-errors.js

Summary

Maintainability
D
2 days
Test Coverage

Function doiFormErrors has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

export function doiFormErrors([model]) {
  let errorAttributes = model.validations.errors.mapBy('attribute');

  // check validation errors for data model fragments if not in draft state
  if (model.state !== 'draft' && ['new', 'edit'].includes(model.mode)) {
Severity: Major
Found in app/helpers/doi-form-errors.js - About 3 hrs to fix

    Function doiFormErrors has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    export function doiFormErrors([model]) {
  let errorAttributes = model.validations.errors.mapBy('attribute');

  // check validation errors for data model fragments if not in draft state
  if (model.state !== 'draft' && ['new', 'edit'].includes(model.mode)) {
    Severity: Minor
    Found in app/helpers/doi-form-errors.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.dates) {
      model.dates.forEach((date) => {
        errorAttributes = errorAttributes.concat(
          date.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 10..16
    app/helpers/doi-form-errors.js on lines 17..23
    app/helpers/doi-form-errors.js on lines 24..30
    app/helpers/doi-form-errors.js on lines 31..37
    app/helpers/doi-form-errors.js on lines 38..44
    app/helpers/doi-form-errors.js on lines 45..51
    app/helpers/doi-form-errors.js on lines 52..58
    app/helpers/doi-form-errors.js on lines 76..82
    app/helpers/doi-form-errors.js on lines 83..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.subjects) {
      model.subjects.forEach((subject) => {
        errorAttributes = errorAttributes.concat(
          subject.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 10..16
    app/helpers/doi-form-errors.js on lines 17..23
    app/helpers/doi-form-errors.js on lines 24..30
    app/helpers/doi-form-errors.js on lines 31..37
    app/helpers/doi-form-errors.js on lines 45..51
    app/helpers/doi-form-errors.js on lines 52..58
    app/helpers/doi-form-errors.js on lines 59..65
    app/helpers/doi-form-errors.js on lines 76..82
    app/helpers/doi-form-errors.js on lines 83..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.creators) {
      model.creators.forEach((creator) => {
        errorAttributes = errorAttributes.concat(
          creator.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 10..16
    app/helpers/doi-form-errors.js on lines 24..30
    app/helpers/doi-form-errors.js on lines 31..37
    app/helpers/doi-form-errors.js on lines 38..44
    app/helpers/doi-form-errors.js on lines 45..51
    app/helpers/doi-form-errors.js on lines 52..58
    app/helpers/doi-form-errors.js on lines 59..65
    app/helpers/doi-form-errors.js on lines 76..82
    app/helpers/doi-form-errors.js on lines 83..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.rightsList) {
      model.rightsList.forEach((rights) => {
        errorAttributes = errorAttributes.concat(
          rights.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 10..16
    app/helpers/doi-form-errors.js on lines 17..23
    app/helpers/doi-form-errors.js on lines 24..30
    app/helpers/doi-form-errors.js on lines 31..37
    app/helpers/doi-form-errors.js on lines 38..44
    app/helpers/doi-form-errors.js on lines 45..51
    app/helpers/doi-form-errors.js on lines 52..58
    app/helpers/doi-form-errors.js on lines 59..65
    app/helpers/doi-form-errors.js on lines 83..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.fundingReferences) {
      model.fundingReferences.forEach((fundingReference) => {
        errorAttributes = errorAttributes.concat(
          fundingReference.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 10..16
    app/helpers/doi-form-errors.js on lines 17..23
    app/helpers/doi-form-errors.js on lines 24..30
    app/helpers/doi-form-errors.js on lines 31..37
    app/helpers/doi-form-errors.js on lines 38..44
    app/helpers/doi-form-errors.js on lines 45..51
    app/helpers/doi-form-errors.js on lines 59..65
    app/helpers/doi-form-errors.js on lines 76..82
    app/helpers/doi-form-errors.js on lines 83..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.relatedItems) {
      model.relatedItems.forEach((relatedItem) => {
        errorAttributes = errorAttributes.concat(
          relatedItem.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 10..16
    app/helpers/doi-form-errors.js on lines 17..23
    app/helpers/doi-form-errors.js on lines 24..30
    app/helpers/doi-form-errors.js on lines 31..37
    app/helpers/doi-form-errors.js on lines 38..44
    app/helpers/doi-form-errors.js on lines 45..51
    app/helpers/doi-form-errors.js on lines 52..58
    app/helpers/doi-form-errors.js on lines 59..65
    app/helpers/doi-form-errors.js on lines 76..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.contributors) {
      model.contributors.forEach((contributor) => {
        errorAttributes = errorAttributes.concat(
          contributor.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 10..16
    app/helpers/doi-form-errors.js on lines 17..23
    app/helpers/doi-form-errors.js on lines 31..37
    app/helpers/doi-form-errors.js on lines 38..44
    app/helpers/doi-form-errors.js on lines 45..51
    app/helpers/doi-form-errors.js on lines 52..58
    app/helpers/doi-form-errors.js on lines 59..65
    app/helpers/doi-form-errors.js on lines 76..82
    app/helpers/doi-form-errors.js on lines 83..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.relatedIdentifiers) {
      model.relatedIdentifiers.forEach((relatedIdentifier) => {
        errorAttributes = errorAttributes.concat(
          relatedIdentifier.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 10..16
    app/helpers/doi-form-errors.js on lines 17..23
    app/helpers/doi-form-errors.js on lines 24..30
    app/helpers/doi-form-errors.js on lines 31..37
    app/helpers/doi-form-errors.js on lines 38..44
    app/helpers/doi-form-errors.js on lines 52..58
    app/helpers/doi-form-errors.js on lines 59..65
    app/helpers/doi-form-errors.js on lines 76..82
    app/helpers/doi-form-errors.js on lines 83..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.alternateIdentifiers) {
      model.alternateIdentifiers.forEach((alternateIdentifier) => {
        errorAttributes = errorAttributes.concat(
          alternateIdentifier.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 10..16
    app/helpers/doi-form-errors.js on lines 17..23
    app/helpers/doi-form-errors.js on lines 24..30
    app/helpers/doi-form-errors.js on lines 38..44
    app/helpers/doi-form-errors.js on lines 45..51
    app/helpers/doi-form-errors.js on lines 52..58
    app/helpers/doi-form-errors.js on lines 59..65
    app/helpers/doi-form-errors.js on lines 76..82
    app/helpers/doi-form-errors.js on lines 83..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

        if (model.titles) {
      model.titles.forEach((title) => {
        errorAttributes = errorAttributes.concat(
          title.validations.errors.mapBy('attribute')
        );
    Severity: Major
    Found in app/helpers/doi-form-errors.js and 9 other locations - About 1 hr to fix
    app/helpers/doi-form-errors.js on lines 17..23
    app/helpers/doi-form-errors.js on lines 24..30
    app/helpers/doi-form-errors.js on lines 31..37
    app/helpers/doi-form-errors.js on lines 38..44
    app/helpers/doi-form-errors.js on lines 45..51
    app/helpers/doi-form-errors.js on lines 52..58
    app/helpers/doi-form-errors.js on lines 59..65
    app/helpers/doi-form-errors.js on lines 76..82
    app/helpers/doi-form-errors.js on lines 83..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status