Sign upLogin

datacite/bracco

View on GitHub
Star
app/services/prefixes.js

Summary

Maintainability
D
2 days
Test Coverage

Function prefix_list has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  prefix_list(n = 1, provider_id = null, query = '') {
    let tot = n < 0 ? 0 : n;
    let prefixes = [];

    let promise = new Promise((resolve, reject) => {
Severity: Minor
Found in app/services/prefixes.js - About 1 hr to fix

    Function promise has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        let promise = new Promise((resolve, reject) => {
      this.store
        .query('provider-prefix', {
          query,
          'provider-id': provider_id,
    Severity: Minor
    Found in app/services/prefixes.js - About 1 hr to fix

      Function get_n_available_pp has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        get_n_available_pp(provider_id = null) {
    let promise = new Promise((resolve, reject) => {
      const url =
        ENV.API_URL +
        '/provider-prefixes?provider-id=' +
      Severity: Minor
      Found in app/services/prefixes.js - About 1 hr to fix

        Function promise has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            let promise = new Promise((resolve, reject) => {
      const url =
        ENV.API_URL +
        '/provider-prefixes?provider-id=' +
        provider_id +
        Severity: Minor
        Found in app/services/prefixes.js - About 1 hr to fix

          Function get_n_available has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            get_n_available() {
    let promise = new Promise((resolve, reject) => {
      const url =
        ENV.API_URL + '/prefixes?page[number]=1&page[size]=0&state=unassigned';
      const headers = { Accept: 'application/json' };
          Severity: Minor
          Found in app/services/prefixes.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  fetch(url, {
        headers
      })
        .then((response) => {
          response.text().then((text) => {
            Severity: Major
            Found in app/services/prefixes.js and 1 other location - About 6 hrs to fix
            app/services/prefixes.js on lines 57..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 157.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  fetch(url, {
        headers
      })
        .then((response) => {
          response.text().then((text) => {
            Severity: Major
            Found in app/services/prefixes.js and 1 other location - About 6 hrs to fix
            app/services/prefixes.js on lines 24..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 157.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status