Sign upLogin

datacite/bracco

View on GitHub
Star
cypress/e2e/client_admin/info.test.ts
b66541bb

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      cy.get('div#client-type div[role="button"]').click({ waitForAnimations: true }).then(() => {
        cy.get('ul.ember-power-select-options li').contains('RAiD Registry').click({ waitForAnimations: true }).then(() => {
          // RAiD Registry client_type divs should be visible
          cy.get('#repository-issn').should('not.exist');
          cy.get('#repository-type').should('be.visible');
Severity: Major
Found in cypress/e2e/client_admin/info.test.ts and 2 other locations - About 5 hrs to fix
cypress/e2e/organization_admin/repositories.test.ts on lines 122..129
cypress/e2e/organization_admin/repositories.test.ts on lines 143..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      cy.get('#chart-doi-title').parent().parent('.panel').within((panel) => {
        cy.get('#chart-doi-title').contains(/DOIs\s*by\s*year/i);
        cy.get('.member.graphs a').and('have.attr', 'href')
          .and('include', '/repositories/datacite.test/dois');
        cy.get('#chart-doi');
Severity: Major
Found in cypress/e2e/client_admin/info.test.ts and 3 other locations - About 3 hrs to fix
cypress/e2e/consortium_admin/info.test.ts on lines 69..74
cypress/e2e/organization_admin/info.test.ts on lines 62..67
cypress/e2e/staff_admin/info.test.ts on lines 66..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

      cy.get('[data-test-left-sidebar]').should('be.visible').within(($sidebar) => {
        // Create DOI button - would like to do more testing but seems impossible in Cypress.
        cy.get('.create-doi-button').contains(/Create DOI/i);
        cy.get('.create-doi-button button.dropdown-toggle').click({ force: true }).then(($obj) => {
          //cy.get('.create-doi-button ul.dropdown-menu')
Severity: Major
Found in cypress/e2e/client_admin/info.test.ts and 2 other locations - About 3 hrs to fix
cypress/e2e/client_admin/doi.test.ts on lines 57..65
cypress/e2e/client_admin/settings.test.ts on lines 44..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  it('/dois redirects to homepage', () => {
    cy.visit('/dois');
    cy.url().should('include', '/repositories/datacite.test').then (() => {
      cy.get('h2.work').contains('DataCite Test Repository');
      cy.get('a#account_menu_link').should('contain', 'DATACITE.TEST');
Severity: Major
Found in cypress/e2e/client_admin/info.test.ts and 8 other locations - About 3 hrs to fix
cypress/e2e/client_admin/info.test.ts on lines 78..84
cypress/e2e/staff_admin/info.test.ts on lines 78..84
cypress/e2e/staff_admin/info.test.ts on lines 86..92
cypress/e2e/staff_admin/info.test.ts on lines 94..100
cypress/e2e/staff_admin/info.test.ts on lines 102..108
cypress/e2e/staff_admin/info.test.ts on lines 110..116
cypress/e2e/staff_admin/info.test.ts on lines 118..124
cypress/e2e/staff_admin/info.test.ts on lines 126..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  it('/prefixes redirects to homepage', () => {
    cy.visit('/prefixes');
    cy.url().should('include', '/repositories/datacite.test').then (() => {
      cy.get('h2.work').contains('DataCite Test Repository');
      cy.get('a#account_menu_link').should('contain', 'DATACITE.TEST');
Severity: Major
Found in cypress/e2e/client_admin/info.test.ts and 8 other locations - About 3 hrs to fix
cypress/e2e/client_admin/info.test.ts on lines 86..92
cypress/e2e/staff_admin/info.test.ts on lines 78..84
cypress/e2e/staff_admin/info.test.ts on lines 86..92
cypress/e2e/staff_admin/info.test.ts on lines 94..100
cypress/e2e/staff_admin/info.test.ts on lines 102..108
cypress/e2e/staff_admin/info.test.ts on lines 110..116
cypress/e2e/staff_admin/info.test.ts on lines 118..124
cypress/e2e/staff_admin/info.test.ts on lines 126..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('can see info when using capitalized identifier URL subdirectory', () => {
    cy.visit('/repositories/DATACITE.TEST');
    cy.url().should('include', '/repositories/DATACITE.TEST').then(() => {
      
      cy.wait(waitTime3)
Severity: Major
Found in cypress/e2e/client_admin/info.test.ts and 1 other location - About 2 hrs to fix
cypress/e2e/consortium_admin/info.test.ts on lines 205..213

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

  it('/settings redirects to homepage', () => {
    cy.visit('/settings');
    cy.url().should('include', '/repositories/datacite.test').then (() => {
      cy.get('a#account_menu_link').should('contain', 'DATACITE.TEST');
    });
Severity: Major
Found in cypress/e2e/client_admin/info.test.ts and 11 other locations - About 2 hrs to fix
cypress/e2e/consortium_admin/info.test.ts on lines 81..86
cypress/e2e/consortium_admin/info.test.ts on lines 88..93
cypress/e2e/consortium_admin/info.test.ts on lines 95..100
cypress/e2e/consortium_admin/info.test.ts on lines 102..107
cypress/e2e/consortium_admin/info.test.ts on lines 109..114
cypress/e2e/consortium_admin/info.test.ts on lines 116..121
cypress/e2e/organization_admin/info.test.ts on lines 74..79
cypress/e2e/organization_admin/info.test.ts on lines 81..86
cypress/e2e/organization_admin/info.test.ts on lines 88..93
cypress/e2e/organization_admin/info.test.ts on lines 95..100
cypress/e2e/organization_admin/info.test.ts on lines 102..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

  before(function () {
    cy.login(Cypress.env('client_admin_username'), Cypress.env('client_admin_password'));
    cy.setCookie('_consent', 'true');
    cy.wait(waitTime2);
  })
Severity: Major
Found in cypress/e2e/client_admin/info.test.ts and 18 other locations - About 1 hr to fix
cypress/e2e/client_admin/doi.test.ts on lines 19..23
cypress/e2e/client_admin/prefixes.test.ts on lines 10..14
cypress/e2e/client_admin/settings.test.ts on lines 8..12
cypress/e2e/consortium_admin/contact.test.ts on lines 23..27
cypress/e2e/consortium_admin/doi.test.ts on lines 15..19
cypress/e2e/consortium_admin/info.test.ts on lines 13..17
cypress/e2e/consortium_admin/organizations.test.ts on lines 10..14
cypress/e2e/consortium_admin/prefixes.test.ts on lines 10..14
cypress/e2e/organization_admin/contact.test.ts on lines 23..27
cypress/e2e/organization_admin/doi.test.ts on lines 13..17
cypress/e2e/organization_admin/info.test.ts on lines 13..17
cypress/e2e/organization_admin/prefixes.test.ts on lines 10..14
cypress/e2e/staff_admin/admin.test.ts on lines 8..12
cypress/e2e/staff_admin/contact.test.ts on lines 26..30
cypress/e2e/staff_admin/info.test.ts on lines 12..16
cypress/e2e/staff_admin/prefix.test.ts on lines 8..12
cypress/e2e/staff_admin/repositories.test.ts on lines 8..12
cypress/e2e/staff_admin/settings.test.ts on lines 8..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      cy.get('.alert.opt-in').contains(/The contacts entered may receive notifications/i)
        .within(() => {
          cy.get('a[href*="privacy-policy"]').should('be.visible');
        }
      );
Severity: Major
Found in cypress/e2e/client_admin/info.test.ts and 3 other locations - About 50 mins to fix
cypress/e2e/consortium_admin/organizations.test.ts on lines 107..111
cypress/e2e/organization_admin/info.test.ts on lines 165..169
cypress/e2e/organization_admin/repositories.test.ts on lines 199..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status