Sign upLogin

datacite/lupo

View on GitHub
Star

Showing 314 of 596 total issues

Method cached_metadata_count has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def cached_metadata_count(options = {})
      Rails.cache.fetch(
        "cached_metadata_count/#{id}",
        expires_in: 6.hours, force: options[:force],
      ) do
Severity: Minor
Found in app/models/concerns/cacheable.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method reverse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def reverse
    {
      "citation" =>
        Array.wrap(object.related_identifiers).select do |ri|
          ri["relationType"] == "IsReferencedBy"
Severity: Minor
Found in app/graphql/types/doi_item.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send_delete_email has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def send_delete_email(responsible_id: nil)
      title = Rails.env.stage? ? "DataCite Fabrica Test" : "DataCite Fabrica"
      subject = "#{title}: Account Deleted"
      account_type =
        if instance_of?(Provider)
Severity: Minor
Found in app/models/concerns/mailable.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method dois_to_import has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def dois_to_import
    [doi_from_url(subj_id), doi_from_url(obj_id)].compact.reduce(
      [],
    ) do |sum, d|
      prefix = d.split("/", 2).first
Severity: Minor
Found in app/models/event.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method client_count has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def client_count(provider_id: nil, consortium_id: nil)
      if provider_id
        response =
          Client.query(
            nil,
Severity: Minor
Found in app/controllers/concerns/countable.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method facet_by_funders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def facet_by_funders(arr)
      arr.map { |hsh|
        funder_id = hsh["key"]

        if funder_id.nil?
Severity: Minor
Found in app/controllers/concerns/facetable.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_token has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def create_token
    if safe_params[:grant_type] != "password"
      error_response("Wrong grant type.") && return
    end
    if safe_params[:username].blank? || safe_params[:username] == "undefined" ||
Severity: Minor
Found in app/controllers/sessions_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cleanse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def cleanse
    xml = add_xml

    meta = generate_meta(xml)
    add_schema_version(meta)
Severity: Minor
Found in app/lib/params_sanitizer.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return false
Severity: Major
Found in app/models/concerns/authenticable.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return false
    Severity: Major
    Found in app/models/concerns/authenticable.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false
      Severity: Major
      Found in app/models/concerns/authenticable.rb - About 30 mins to fix

        Method response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def response(**args)
    Doi.gql_query(
      args[:query],
      ids: args[:ids],
      user_id: args[:user_id],
        Severity: Minor
        Found in app/graphql/types/member_type.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_one_author has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def get_one_author(author, _options = {})
      return { "literal" => "" } if author.strip.blank?

      author = cleanup_author(author)
      names = Namae.parse(author)
        Severity: Minor
        Found in app/models/concerns/authorable.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def get_url
      url = "#{ENV['HANDLE_URL']}/api/handles/#{doi}?index=1"
      response = Maremma.get(url, ssl_self_signed: true, timeout: 10)

      if response.status != 200
        Severity: Minor
        Found in app/models/concerns/helpable.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method perform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def perform(doi_id, options = {})
    doi = Doi.where(doi: doi_id).first

    if doi.present? && options[:client_target_id].present?
      __elasticsearch__.index_document if doi.update(datacentre: options[:client_target_id]) == true
        Severity: Minor
        Found in app/jobs/transfer_job.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method actors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def actors(**args)
    orgs = Organization.query(args[:query], offset: args[:after].present? ? Base64.urlsafe_decode64(args[:after]) : nil)
    funders = Funder.query(args[:query], limit: args[:first], offset: args[:after].present? ? Base64.urlsafe_decode64(args[:after]) : nil)
    people = Person.query(args[:query], limit: args[:first], offset: args[:after].present? ? Base64.urlsafe_decode64(args[:after]) : nil)
        Severity: Minor
        Found in app/graphql/types/query_type.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method perform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def perform(id, _options = {})
    doi = Doi.where(doi: id, schema_version: nil).first
    xml = doi.xml
    metadata = xml.present? ? parse_xml(xml, doi: id) : {}
        Severity: Minor
        Found in app/jobs/schema_version_job.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method encode_alb_token has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def encode_alb_token(payload)
      return nil if payload.blank? || !Rails.env.test?

      # replace newline characters with actual newlines
      private_key =
        Severity: Minor
        Found in app/models/concerns/authenticable.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method people has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def people(**args)
    grid_query = "grid-org-id:#{object.grid}"
    ringgold_query =
      object.ringgold.present? ? "ringgold-org-id:#{object.ringgold}" : ""
    org_query = [grid_query, ringgold_query].compact.join(" OR ")
        Severity: Minor
        Found in app/graphql/types/organization_type.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method encode_globus_token has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def encode_globus_token(payload)
      return nil if payload.blank? || !Rails.env.test?

      # replace newline characters with actual newlines
      private_key =
        Severity: Minor
        Found in app/models/concerns/authenticable.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language