Sign upLogin

datahuborg/datahub

View on GitHub
Star
src/apps/dbwipes/static/js/summary/setup.js

Summary

Maintainability
F
3 wks
Test Coverage

Function setupBasic has 145 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var setupBasic = function() {
    var q = new Query();
    var qv = new QueryView({ model: q })
    $("#right").prepend(qv.render().$el);
Severity: Major
Found in src/apps/dbwipes/static/js/summary/setup.js - About 5 hrs to fix

    File setup.js has 304 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    define(function(require) {
  var Backbone = require('backbone'),
      $ = require('bootstrap'),
      d3 = require('d3'),
      _ = require('underscore'),
    Severity: Minor
    Found in src/apps/dbwipes/static/js/summary/setup.js - About 3 hrs to fix

      Function setupScorpion has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var setupScorpion = function(enableScorpion, q, qv, where) {
    if (!enableScorpion) {
      $("#facet-togglecheckall").css("opacity", 0);
      return;
    }
      Severity: Major
      Found in src/apps/dbwipes/static/js/summary/setup.js - About 2 hrs to fix

        Function setupButtons has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          var setupButtons = function(q, qv) {
    $("[data-toggle=tooltip]").tooltip();

    var st_on_text = "Visualization shows what data matching your filter" ,
        st_off_text = "Visualization removes data matching your filter";
        Severity: Minor
        Found in src/apps/dbwipes/static/js/summary/setup.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          define(function(require) {
  var Backbone = require('backbone'),
      $ = require('bootstrap'),
      d3 = require('d3'),
      _ = require('underscore'),
          Severity: Major
          Found in src/apps/dbwipes/static/js/summary/setup.js and 1 other location - About 2 wks to fix
          src/browser/static/dbwipes/js/summary/setup.js on lines 1..345

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 3209.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status