Sign upLogin

datahuborg/datahub

View on GitHub
Star
src/browser/static/dbwipes/js/summary/queryview.js

Summary

Maintainability
F
1 mo
Test Coverage

File queryview.js has 509 lines of code (exceeds 250 allowed). Consider refactoring.
Open

define(function(require) {
  var Backbone = require('backbone'),
      Handlebars = require('handlebars'),
      $ = require('jquery'),
      d3 = require('d3'),
Severity: Major
Found in src/browser/static/dbwipes/js/summary/queryview.js - About 1 day to fix

    Function renderZoom has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        renderZoom: function(el) {
      var _this = this
          yscales = this.state.yscales,
          yaxis = this.state.yaxis,
          xscales = this.state.xscales,
    Severity: Major
    Found in src/browser/static/dbwipes/js/summary/queryview.js - About 4 hrs to fix

      Function setupScales has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          setupScales: function(data) {
      var schema = this.model.get('schema'),
          xcol = this.model.get('x'),
          xalias = xcol.alias,
          ycols = this.model.get('ys'),
      Severity: Major
      Found in src/browser/static/dbwipes/js/summary/queryview.js - About 2 hrs to fix

        Function renderBrush has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            renderBrush: function(el) {
      if (el.select('.brush').size() > 0) {
        console.log(['qv.renderBrush', 'exists, skip']);
        return;
      }
        Severity: Major
        Found in src/browser/static/dbwipes/js/summary/queryview.js - About 2 hrs to fix

          Function renderAxes has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              renderAxes: function(el) {
      if(el.select('.xaxis').size() == 0) {
        var xel = el.append('g')
          .attr('class', 'axis x xaxis')
          .attr('transform', "translate(0,"+this.state.h+")");
          Severity: Minor
          Found in src/browser/static/dbwipes/js/summary/queryview.js - About 1 hr to fix

            Function renderData has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                renderData: function(el, data, xalias, yalias) {
      var _this = this,
          h = this.state.h,
          w = this.state.w;
      var data = _.map(data, function(d) {
            Severity: Minor
            Found in src/browser/static/dbwipes/js/summary/queryview.js - About 1 hr to fix

              Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  render: function() {
      if (!this.model.isValid()) {
        this.$svg.hide();
        return this;
      }
              Severity: Minor
              Found in src/browser/static/dbwipes/js/summary/queryview.js - About 1 hr to fix

                Function renderModifiedData has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    renderModifiedData: function(data) {
      var _this = this;
      this.$(".updated").remove();
      this.c.selectAll('g.data-container')
        .classed('background', false)
                Severity: Minor
                Found in src/browser/static/dbwipes/js/summary/queryview.js - About 1 hr to fix

                  Function brushf has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        var brushf = function(p) {
        var e = brush.extent()
        var selected = {};
        el.selectAll('.data-container:not(.background)')
            .selectAll('.mark')
                  Severity: Minor
                  Found in src/browser/static/dbwipes/js/summary/queryview.js - About 1 hr to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    define(function(require) {
  var Backbone = require('backbone'),
      Handlebars = require('handlebars'),
      $ = require('jquery'),
      d3 = require('d3'),
                    Severity: Major
                    Found in src/browser/static/dbwipes/js/summary/queryview.js and 1 other location - About 1 mo to fix
                    src/apps/dbwipes/static/js/summary/queryview.js on lines 1..610

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 6289.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status