Sign upLogin

davidmigloz/go-bees

View on GitHub
Star

Showing 118 of 387 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void deleteApiaryError_showError() {
        apiariesPresenter.deleteApiary(APIARIES.get(0));
        // Delete apiary error
        verify(goBeesRepository).deleteApiary(eq(APIARIES.get(0).getId()),
Severity: Minor
Found in app/src/test/java/com/davidmiguel/gobees/apiaries/ApiariesPresenterTest.java and 1 other location - About 45 mins to fix
app/src/test/java/com/davidmiguel/gobees/apiaries/ApiariesPresenterTest.java on lines 159..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    RecordingsAdapter(Context context, MenuInflater menuInflater,
                      List<Recording> recordings, RecordingItemListener listener) {
        this.context = context;
        this.menuInflater = menuInflater;
        this.recordings = checkNotNull(recordings);
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/hive/RecordingsAdapter.java and 1 other location - About 40 mins to fix
app/src/main/java/com/davidmiguel/gobees/apiaries/ApiariesAdapter.java on lines 56..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    ApiariesAdapter(Context context, MenuInflater menuInflater, List<Apiary> apiaries,
                    ApiaryItemListener listener) {
        this.context = context;
        this.menuInflater = menuInflater;
        this.apiaries = checkNotNull(apiaries);
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/apiaries/ApiariesAdapter.java and 1 other location - About 40 mins to fix
app/src/main/java/com/davidmiguel/gobees/hive/RecordingsAdapter.java on lines 71..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void setErodeKernel(int size) {
        switch (size) {
            case 1:
                kernelErode = KERNEL1;
                break;
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/monitoring/algorithm/processors/Morphology.java and 1 other location - About 40 mins to fix
app/src/main/java/com/davidmiguel/gobees/monitoring/algorithm/processors/Morphology.java on lines 99..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void setDilateKernel(int size) {
        switch (size) {
            case 1:
                kernelDilate = KERNEL1;
                break;
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/monitoring/algorithm/processors/Morphology.java and 1 other location - About 40 mins to fix
app/src/main/java/com/davidmiguel/gobees/monitoring/algorithm/processors/Morphology.java on lines 80..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        ViewInteraction appCompatCheckedTextView2 = onView(
                allOf(withId(android.R.id.text1), withText("Metric (°C, km/h…)"),
                        childAtPosition(
                                allOf(withClassName(is(
                                        "com.android.internal.app." +
Severity: Minor
Found in app/src/androidTest/java/com/davidmiguel/gobees/settings/SettingsTest.java and 1 other location - About 40 mins to fix
app/src/androidTest/java/com/davidmiguel/gobees/settings/SettingsTest.java on lines 123..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        ViewInteraction appCompatCheckedTextView3 = onView(
                allOf(withId(android.R.id.text1), withText("Imperial (°F, mph…)"),
                        childAtPosition(
                                allOf(withClassName(
                                        is("com.android.internal.app." +
Severity: Minor
Found in app/src/androidTest/java/com/davidmiguel/gobees/settings/SettingsTest.java and 1 other location - About 40 mins to fix
app/src/androidTest/java/com/davidmiguel/gobees/settings/SettingsTest.java on lines 100..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for (int i = 1; i <= 3; i++) {
            morf.setDilateKernel(i);
            result = morf.process(source);
            assertMatEqual(black, result);
        }
Severity: Minor
Found in app/src/testMock/java/com/davidmiguel/gobees/monitoring/algorithm/processors/ProcessorsTest.java and 1 other location - About 40 mins to fix
app/src/testMock/java/com/davidmiguel/gobees/monitoring/algorithm/processors/ProcessorsTest.java on lines 132..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for (int i = 1; i <= 3; i++) {
            morf.setErodeKernel(i);
            result = morf.process(source);
            assertMatEqual(black, result);
        }
Severity: Minor
Found in app/src/testMock/java/com/davidmiguel/gobees/monitoring/algorithm/processors/ProcessorsTest.java and 1 other location - About 40 mins to fix
app/src/testMock/java/com/davidmiguel/gobees/monitoring/algorithm/processors/ProcessorsTest.java on lines 127..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void formatWindKmh() throws Exception {
        // Set metric system
        when(GoBeesPreferences.isMetric(Matchers.<Context>any()))
                .thenReturn(true);
Severity: Minor
Found in app/src/test/java/com/davidmiguel/gobees/utils/WeatherUtilsTest.java and 1 other location - About 35 mins to fix
app/src/test/java/com/davidmiguel/gobees/utils/WeatherUtilsTest.java on lines 109..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void formatWindMph() throws Exception {
        // Set metric system
        when(GoBeesPreferences.isMetric(Matchers.<Context>any()))
                .thenReturn(false);
Severity: Minor
Found in app/src/test/java/com/davidmiguel/gobees/utils/WeatherUtilsTest.java and 1 other location - About 35 mins to fix
app/src/test/java/com/davidmiguel/gobees/utils/WeatherUtilsTest.java on lines 100..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        ViewInteraction frameLayout = onView(
                allOf(withId(R.id.card),
                        childAtPosition(
                                allOf(withId(R.id.hives_list),
                                        childAtPosition(
Severity: Major
Found in app/src/androidTest/java/com/davidmiguel/gobees/apiary/DeleteHiveTest.java and 5 other locations - About 35 mins to fix
app/src/androidTest/java/com/davidmiguel/gobees/apiaries/DeleteApiaryTest.java on lines 119..127
app/src/androidTest/java/com/davidmiguel/gobees/hive/AddRecordingTest.java on lines 147..155
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 114..122
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 125..133
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 136..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        ViewInteraction frameLayout = onView(
                allOf(withId(R.id.card),
                        childAtPosition(
                                allOf(withId(R.id.apiaries_list),
                                        childAtPosition(
Severity: Major
Found in app/src/androidTest/java/com/davidmiguel/gobees/apiaries/DeleteApiaryTest.java and 5 other locations - About 35 mins to fix
app/src/androidTest/java/com/davidmiguel/gobees/apiary/DeleteHiveTest.java on lines 133..141
app/src/androidTest/java/com/davidmiguel/gobees/hive/AddRecordingTest.java on lines 147..155
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 114..122
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 125..133
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 136..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        ViewInteraction frameLayout2 = onView(
                allOf(withId(R.id.card),
                        childAtPosition(
                                allOf(withId(R.id.recordings_list),
                                        childAtPosition(
Severity: Major
Found in app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java and 5 other locations - About 35 mins to fix
app/src/androidTest/java/com/davidmiguel/gobees/apiaries/DeleteApiaryTest.java on lines 119..127
app/src/androidTest/java/com/davidmiguel/gobees/apiary/DeleteHiveTest.java on lines 133..141
app/src/androidTest/java/com/davidmiguel/gobees/hive/AddRecordingTest.java on lines 147..155
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 114..122
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 136..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        ViewInteraction frameLayout = onView(
                allOf(withId(R.id.card),
                        childAtPosition(
                                allOf(withId(R.id.recordings_list),
                                        childAtPosition(
Severity: Major
Found in app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java and 5 other locations - About 35 mins to fix
app/src/androidTest/java/com/davidmiguel/gobees/apiaries/DeleteApiaryTest.java on lines 119..127
app/src/androidTest/java/com/davidmiguel/gobees/apiary/DeleteHiveTest.java on lines 133..141
app/src/androidTest/java/com/davidmiguel/gobees/hive/AddRecordingTest.java on lines 147..155
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 125..133
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 136..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        ViewInteraction frameLayout = onView(
                allOf(withId(R.id.card),
                        childAtPosition(
                                allOf(withId(R.id.recordings_list),
                                        childAtPosition(
Severity: Major
Found in app/src/androidTest/java/com/davidmiguel/gobees/hive/AddRecordingTest.java and 5 other locations - About 35 mins to fix
app/src/androidTest/java/com/davidmiguel/gobees/apiaries/DeleteApiaryTest.java on lines 119..127
app/src/androidTest/java/com/davidmiguel/gobees/apiary/DeleteHiveTest.java on lines 133..141
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 114..122
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 125..133
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 136..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        ViewInteraction frameLayout3 = onView(
                allOf(withId(R.id.card),
                        childAtPosition(
                                allOf(withId(R.id.recordings_list),
                                        childAtPosition(
Severity: Major
Found in app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java and 5 other locations - About 35 mins to fix
app/src/androidTest/java/com/davidmiguel/gobees/apiaries/DeleteApiaryTest.java on lines 119..127
app/src/androidTest/java/com/davidmiguel/gobees/apiary/DeleteHiveTest.java on lines 133..141
app/src/androidTest/java/com/davidmiguel/gobees/hive/AddRecordingTest.java on lines 147..155
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 114..122
app/src/androidTest/java/com/davidmiguel/gobees/hive/ListRecordingsTest.java on lines 125..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            @Override
            public void onDataNotAvailable() {
                // The hiveRecordingsView may not be able to handle UI updates anymore
                if (!hiveRecordingsView.isActive() || !hiveInfoView.isActive()) {
                    return;
Severity: Minor
Found in app/src/main/java/com/davidmiguel/gobees/hive/HivePresenter.java and 1 other location - About 35 mins to fix
app/src/main/java/com/davidmiguel/gobees/apiary/ApiaryPresenter.java on lines 108..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void loadRecordingsError_showMsg() {
        // Given an initialized HivePresenter
        // When loading of recordings is requested
        hivePresenter.start(); // Recordings list fragment
Severity: Minor
Found in app/src/test/java/com/davidmiguel/gobees/hive/HivePresenterTest.java and 1 other location - About 35 mins to fix
app/src/test/java/com/davidmiguel/gobees/apiary/ApiaryPresenterTest.java on lines 113..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    public void loadHivesError_showMsg() {
        // Given an initialized ApiaryPresenter
        // When loading of apiaries is requested
        apiaryPresenter.start(); // Hive list fragment
Severity: Minor
Found in app/src/test/java/com/davidmiguel/gobees/apiary/ApiaryPresenterTest.java and 1 other location - About 35 mins to fix
app/src/test/java/com/davidmiguel/gobees/hive/HivePresenterTest.java on lines 122..134

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language