Sign upLogin

dawn/dawn

View on GitHub
Star

Showing 4 of 11 total issues

Class AppsController has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class AppsController < ApiController
  actions = [:index, :create]
  before_action :find_app, except: actions
  before_action :verify_app_owner, except: actions
Severity: Minor
Found in app/controllers/apps_controller.rb - About 2 hrs to fix

    Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    unless params[:command].present?
      response = { id: "run.command.invalid",
                   message: "invalid command given (#{params[:command]})" }
      render json: response, status: 400
    Severity: Minor
    Found in app/controllers/apps_controller.rb - About 1 hr to fix

      Method scale has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def scale(options)
    # retrieve the App's Procfile data
    allowed_proctypes = proctypes.keys
    old_formation = self.formation
      Severity: Minor
      Found in app/models/app.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ensure_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def ensure_name
    if name.blank?
      loop do
        self.name = Forgery(:dawn).app_name
        break if name.size.between?(3, 16) &&
      Severity: Minor
      Found in app/models/app.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language