Sign upLogin

dbrady/baseball-statsification-monkey

View on GitHub
Star

Showing 2 of 2 total issues

Class Batter has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class Batter
  extend Forwardable

  attr_reader :id, :last_name, :first_name
  private_attr_reader :batting_data
Severity: Minor
Found in lib/batter.rb - About 2 hrs to fix

    Method find_all has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.find_all(year: nil, league: nil, team: nil)
    return batter_data.map(&:last) unless year
    return find_all_by_year(year) unless league || team
    # subtle: if you supply both league and team, ignore league
    return find_all_by_league_and_year(league, year) unless team
    Severity: Minor
    Found in lib/batter.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language