Sign upLogin

dcardenascom/lemonway-php

View on GitHub
Star

Showing 10 of 10 total issues

WalletModel has 67 functions (exceeds 20 allowed). Consider refactoring.
Open

class WalletModel extends LemonwayObjectModel
{
    const ACTION_GET_WALLET_DETAILS = 'GetWalletDetails';
    const ACTION_GET_KYC_STATUS = 'GetKycStatus';
    const ACTION_UPDATE_WALLET_DETAILS = 'UpdateWalletDetails';
Severity: Major
Found in src/Models/WalletModel.php - About 1 day to fix

    File WalletModel.php has 452 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Created by David Cardenas
 * GitHub: https://github.com/dcardenascom
 * GitLab: https://gitlab.com/dcardenas
    Severity: Minor
    Found in src/Models/WalletModel.php - About 6 hrs to fix

      Method bindFromLemonway has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function bindFromLemonway(stdClass $object): bool
    {
        $map = [
            'ID'                 => 'setId',
            'BAL'                => 'setBalance',
      Severity: Minor
      Found in src/Models/WalletModel.php - About 1 hr to fix

        Function bindFromLemonway has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function bindFromLemonway(stdClass $object): bool
    {
        $map = [
            'ID'                 => 'setId',
            'BAL'                => 'setBalance',
        Severity: Minor
        Found in src/Models/WalletModel.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method updateDetailsToLemonway has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function updateDetailsToLemonway(ClientModel $clientModel): bool
    {
        if ('' === $this->getId()) {
            throw new ParameterNotFoundException('Please provide wallet id');
        }
        Severity: Minor
        Found in src/Models/WalletModel.php - About 1 hr to fix

          Method downloadDocumentFile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function downloadDocumentFile(string $backofficeBaseUrl, int $walletProviderId, int $documentProviderId)
    {
        try {
            $gouteClient = new GouteClient();
            $crawler = $gouteClient->request('GET', $backofficeBaseUrl);
          Severity: Minor
          Found in src/Models/ClientModel.php - About 1 hr to fix

            Function getErrorsFromContent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getErrorsFromContent(stdClass $content): string
    {
        $errorMessage = '';

        if (is_object($content) && property_exists($content, 'd')) {
            Severity: Minor
            Found in src/Models/ClientModel.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getResponseFromAPI has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getResponseFromAPI(string $action, array $parameters = []): stdClass
    {
        $mandatoryParameters = [
            'wlLogin'  => $this->lemonwayCredentials->getUsername(),
            'wlPass'   => $this->lemonwayCredentials->getPassword(),
            Severity: Minor
            Found in src/Models/ClientModel.php - About 1 hr to fix

              Method toArray has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function toArray(): array
    {
        $arrayToReturn = [
            'id'                  => $this->getId(),
            'balance'             => $this->getBalance(),
              Severity: Minor
              Found in src/Models/WalletModel.php - About 1 hr to fix

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        CredentialsModel $lemonwayCredentials,
        string $directKitUrl,
        string $version = self::DEFAULT_VERSION,
        string $language = self::DEFAULT_LANGUAGE,
        $ip = null
                Severity: Minor
                Found in src/Models/ClientModel.php - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language