deeplearning4j/deeplearning4j

View on GitHub
deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-vertx/src/main/resources/deeplearning4jUiAssets/js/samediff/samediff-ui.js

Summary

Maintainability
F
1 wk
Test Coverage

Function readGraphStructure has a Cognitive Complexity of 178 (exceeds 5 allowed). Consider refactoring.
Open

function readGraphStructure(){
    //First: load data
    if (file) {
        var fr = new FileReader();
        var fileData = new Blob([file]);            //TODO Don't load the whole file into memory at once!

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readGraphStructure has 244 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function readGraphStructure(){
    //First: load data
    if (file) {
        var fr = new FileReader();
        var fileData = new Blob([file]);            //TODO Don't load the whole file into memory at once!

    Function onload has 237 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            fr.onload = function () {
                var arrayBuffer = fr.result;
                var bytes = new Uint8Array(arrayBuffer);
                //console.log(bytes);
    
    

      File samediff-ui.js has 332 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
       *  ******************************************************************************
       *  *
       *  *
       *  * This program and the accompanying materials are made available under the

        Avoid deeply nested control flow statements.
        Open

                                for (var j = 0; j < cdLength; j++) {
                                    var varName = o.controlDeps(j);
                                    //If placeholder, variable or constant, make edge from variable node
                                    //If array, make edge from op node
        
        

          Avoid deeply nested control flow statements.
          Open

                                  if (extraLabel != null && extraLabel !== "") {
                                      n = n + "\n" + extraLabel;
                                  }

            Avoid deeply nested control flow statements.
            Open

                                    if (v.inputsForOpLength() > 0) {
                                        for (var j = 0; j < v.inputsForOpLength(); j++) {
                                            var opName = v.inputsForOp(j);
                                            opName = idEscapeSlashes(opName);
                                            var edgeObj = {

              Avoid deeply nested control flow statements.
              Open

                                      if (vcdCount > 0) {
                                          for (var j = 0; j < vcdCount; j++) {
                                              var vcd = v.controlDeps(j);
              
                                              //2 possibilities: variable is a variable/constant/placeholder: source is from variable node

                Avoid deeply nested control flow statements.
                Open

                                        if (vType === nd4j.graph.VarType.VARIABLE) {
                                            renderStyle = "uivariable variable";
                                        } else if (vType === nd4j.graph.VarType.PLACEHOLDER) {
                                            renderStyle = "uivariable placeholder";
                                        } else if (vType === nd4j.graph.VarType.CONSTANT) {

                  Avoid deeply nested control flow statements.
                  Open

                                          if (vType === nd4j.graph.VarType.CONSTANT) {
                                              var constArr = v.constantValue();
                                              if (constArr != null) {
                                                  if (constArr.shapeLength() === 0 && constArr.bufferLength() > 0) {
                                                      var scalar = scalarFromFlatArray(constArr);

                    Avoid deeply nested control flow statements.
                    Open

                                            for (var j = 0; j < ol; j++) {
                                                var outVarName = o.outputs(j);
                                                var outVar = sdGraphVariableMap.get(outVarName);
                                                var outVarInputCount = outVar.inputsForOpLength();
                    
                    

                      Identical blocks of code found in 3 locations. Consider refactoring.
                      Open

                                                  if (vType === nd4j.graph.VarType.CONSTANT || vType === nd4j.graph.VarType.PLACEHOLDER || vType === nd4j.graph.VarType.VARIABLE) {
                                                      edgeObj = {
                                                          source: "var-" + varName,
                                                          target: id,
                                                          label: ""
                      deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-vertx/src/main/resources/deeplearning4jUiAssets/js/samediff/samediff-graph.js on lines 173..177
                      deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-vertx/src/main/resources/deeplearning4jUiAssets/js/samediff/samediff-ui.js on lines 151..237

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 58.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 3 locations. Consider refactoring.
                      Open

                                          if (vType === nd4j.graph.VarType.CONSTANT || vType === nd4j.graph.VarType.PLACEHOLDER || vType === nd4j.graph.VarType.VARIABLE) {
                                              var dt = dataTypeToString(v.datatype());
                                              var shape = varShapeToString(v);
                                              var n = "\"" + name + "\"\n" + varTypeToString(vType) + "\n" + dt + " " + shape;
                      
                      
                      deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-vertx/src/main/resources/deeplearning4jUiAssets/js/samediff/samediff-graph.js on lines 173..177
                      deeplearning4j/deeplearning4j-ui-parent/deeplearning4j-vertx/src/main/resources/deeplearning4jUiAssets/js/samediff/samediff-ui.js on lines 322..336

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 58.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status