Showing 32 of 74 total issues
Avoid deeply nested control flow statements. Open
if grab:
log("Indexing %s at point %d" % (grab, len(retHeaders)))
retHeaders.append(grab)
if not grab in retDict:
log("Identifying new header: %s" % grab)Avoid deeply nested control flow statements. Open
if line[0] == "{":
#Group match!
grab, line = line.split("}", 1)
line = line.strip() #Must clear trailing spaces
grab = grab.strip("{}")Function _binaryDecode has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def _binaryDecode(filehandle, chunksize, decoder, targetarray, headers, extraCaptures):Function convertOmfToImage has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def convertOmfToImage(omf, tclCall, oommfPath, confpath, stdinRedirect, mode='advanced'):Function write has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def write(filename, interpreter, delim, fields):
"""
"""
print("Write out to:", filename)
refdelim = delim- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function doImages has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def doImages(targetList, stdinRedirect, config_parent, tclCall, OOMMFPath):Function OnDropFiles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def OnDropFiles(self, x, y, filenames):
"""
"""
namepotential = filterOnExtensions(["odt"], filenames)
if not self.parent.batchModeCheckbox.GetValue() or not self.parent.digest:- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function runSubProcess has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def runSubProcess(command, stdinRedirect, mode, checkPath):
if mode == "basic":
os.system(command)
elif mode == 'advanced':
pipe = subprocess.Popen(command, **getSubProcessArgs(command,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this function. Open
return 1Function _textDecode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def _textDecode(filehandle, targetarray, headers, extraCaptures):
"""
"""
valm = headers.get("valuemultiplier", 1)
for k in range(int(headers["znodes"])):- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function groupUnpack has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def groupUnpack(self, targetlist, progdialog=None):
"""
"""
try:
(decodedArrays, headers, extraData) = oommfdecode.groupUnpack(targetlist)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getOOMMFPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def getOOMMFPath(pathFileToCheck):
# Check if we have a saved OOMMF path to use as config data
if os.path.exists(pathFileToCheck):
f = open(pathFileToCheck)
lines = f.readlines()- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"