Sign upLogin

department-of-veterans-affairs/caseflow

View on GitHub
Star

Showing 23 of 1,045 total issues

Consider simplifying this complex logical expression.
Open

    if (option.value === props.value) {
      return (
        <React.Fragment>
          { renderMst && <div>
            <Checkbox
Severity: Critical
Found in client/app/intake/components/IntakeRadioField.jsx - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

      if (currentType === 'SendInitialNotificationLetterTask') {
    return (
      <React.Fragment>
        <div className="cc_mark_complete">
          {taskConfiguration && StringUtil.nl2br(taskConfiguration.modal_body)}
    Severity: Critical
    Found in client/app/queue/components/CompleteTaskModal.jsx - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

        if (props.task.type === 'SendInitialNotificationLetterTask' ||
    props.task.type === 'PostSendInitialNotificationLetterHoldingTask' ||
    props.task.type === 'SendFinalNotificationLetterTask') {
    return (
      <QueueFlowModal
      Severity: Critical
      Found in client/app/queue/components/CancelTaskModal.jsx - About 1 hr to fix

        Method email_request has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def email_request(participant_id, notification_id, email_template_id, first_name, docket_number, status)
        Severity: Minor
        Found in app/services/external_api/va_notify_service.rb - About 45 mins to fix

          Method send_email_notifications has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                participant_id,
      notification_id,
      email_template_id,
      first_name,
      docket_number,
          Severity: Minor
          Found in lib/fakes/va_notify_service.rb - About 45 mins to fix

            Method send_sms_notifications has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  participant_id,
      notification_id,
      sms_template_id,
      first_name,
      docket_number,
            Severity: Minor
            Found in lib/fakes/va_notify_service.rb - About 45 mins to fix

              Method distribute_nonpriority_appeals has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def self.distribute_nonpriority_appeals(judge, genpop, range, limit, bust_backlog, dry_run = false)
              Severity: Minor
              Found in app/models/vacols/case_docket.rb - About 45 mins to fix

                Method send_email_notifications has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      participant_id,
      notification_id,
      email_template_id,
      first_name,
      docket_number,
                Severity: Minor
                Found in app/services/external_api/va_notify_service.rb - About 45 mins to fix

                  Method sms_request has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def sms_request(participant_id, notification_id, sms_template_id, first_name, docket_number, status)
                  Severity: Minor
                  Found in app/services/external_api/va_notify_service.rb - About 45 mins to fix

                    Method send_sms_notifications has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def send_sms_notifications(participant_id, notification_id, sms_template_id, first_name, docket_number, status = "")
                    Severity: Minor
                    Found in app/services/external_api/va_notify_service.rb - About 45 mins to fix

                      Consider simplifying this complex logical expression.
                      Open

                            if @va_notify_email && @va_notify_sms && event_type != "Quarterly Notification" ||
         @va_notify_email && @va_notify_quarterly_sms && event_type == "Quarterly Notification"
        "Email and SMS"
      elsif @va_notify_email
        "Email"
                      Severity: Major
                      Found in app/jobs/send_notification_job.rb - About 40 mins to fix

                        Method get_dates_between has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          def get_dates_between(start_date, end_date, num_of_dates,
                        exclude_weekends = true, max_same_date = 4)
                        Severity: Minor
                        Found in spec/fake_date_helper.rb - About 35 mins to fix

                          Method distribute_nonpriority_appeals has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def distribute_nonpriority_appeals(judge, genpop, range, limit, bust_backlog)
                          Severity: Minor
                          Found in app/repositories/appeal_repository.rb - About 35 mins to fix

                            Method cancel_end_product has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                              def cancel_end_product(veteran_file_number, end_product_code, end_product_modifier, payee_code, benefit_type)
                            Severity: Minor
                            Found in app/services/external_api/bgs_service.rb - About 35 mins to fix

                              Method cancel_end_product has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                def cancel_end_product(file_number, end_product_code, end_product_modifier, payee_code, _benefit_type)
                              Severity: Minor
                              Found in lib/fakes/bgs_service.rb - About 35 mins to fix

                                Method log_info has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                  def log_info(start_time, task_count_for, error_count, hearing_ids, err = nil)
                                Severity: Minor
                                Found in app/jobs/hearing_disposition_change_job.rb - About 35 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                        return :pending_certification
                                  Severity: Major
                                  Found in app/models/appeal_series.rb - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                        return false;
                                    Severity: Major
                                    Found in client/app/intake/util/issues.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                        return {
    x,
    y
  };
                                      Severity: Major
                                      Found in client/app/reader/utils.js - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                            return false if ancestor_task_of_type(EvidenceSubmissionWindowTask).present?
                                        Severity: Major
                                        Found in app/models/task.rb - About 30 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language