Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star

Showing 4,231 of 14,884 total issues

Consider simplifying this complex logical expression.
Open

    if (inquiryData?.attributes?.status) {
      const { status } = inquiryData.attributes;
      return (
        <>
          <h3 className="vads-u-font-weight--normal vads-u-font-size--base vads-u-font-family--sans vads-u-border-bottom--2px vads-u-border-color--gray-light vads-u-padding-bottom--2">
Severity: Critical
Found in src/applications/ask-va/containers/IntroductionPage.jsx - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

          if (err?.errors?.[0]?.code === '401' || err?.issue?.[0]?.code === '401') {
        errorTitle =
          err?.errors?.[0]?.title ||
          err?.issue?.[0]?.diagnostics ||
          'Not authorized';
    Severity: Critical
    Found in src/applications/vaos/utils/error.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

          if (showTuitionAndFilters) {
      return (
        <>
          {!smallScreen && (
            <>
      Severity: Critical
      Found in src/applications/gi/containers/search/LocationSearchResults.jsx - About 1 hr to fix

        Function generateInfoForAvailableRecords has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const generateInfoForAvailableRecords = (infoSection, doc, data) => {
  infoSection.add(
    createHeading(doc, 'H2', config, 'Records in this report', {
      x: 20,
      paragraphGap: 12,
        Severity: Minor
        Found in src/platform/pdf/templates/blue_button_report.js - About 1 hr to fix

          Function PersonalizationDropdown has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function PersonalizationDropdown(props) {
  const { isSSOe, csp } = props;

  const createSignout = useCallback(
    () => (
          Severity: Minor
          Found in src/platform/site-wide/user-nav/components/PersonalizationDropdown.jsx - About 1 hr to fix

            Function render has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              render() {
    const { makeForm } = this;
    const { cssClass, clickHandler, isOpen } = this.props;

    const buttonClasses = classNames(
            Severity: Minor
            Found in src/platform/site-wide/user-nav/components/SearchMenu.jsx - About 1 hr to fix

              Function itemPage has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                pageBuilder.itemPage = pageConfig => {
    const requiredOpts = ['title', 'path', 'uiSchema', 'schema'];
    verifyRequiredPropsPageConfig('itemPage', requiredOpts, pageConfig);
    const { onNavBack, onNavForward } = getNavItem(pageConfig.path);
              Severity: Minor
              Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx - About 1 hr to fix

                Function useVaDateCommon has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export function useVaDateCommon(props) {
  const mappedProps = vaDateCommonFieldMapping(props);
  const [values, setValues] = useState(parseISODate(mappedProps.value));
  const monthYearOnly = props?.uiOptions?.monthYearOnly;
                Severity: Minor
                Found in src/platform/forms-system/src/js/web-component-fields/useVaDateCommon.js - About 1 hr to fix

                  Function YesNoField has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export default function YesNoField(props) {
  const mappedProps = vaRadioFieldMapping(props);

  const labels = props.uiOptions?.labels || {};
                  Severity: Minor
                  Found in src/platform/forms-system/src/js/web-component-fields/YesNoField.jsx - About 1 hr to fix

                    Function mapStateToProps has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export function mapStateToProps(state, ownProps) {
  // from ownprops
  const { formConfig, formContext, pageList } = ownProps;

  // from redux state
                    Severity: Minor
                    Found in src/platform/forms-system/src/js/review/ReviewChapters.jsx - About 1 hr to fix

                      Function data has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        data: (state = initialState, action) => {
    switch (action.type) {
      case FETCH_VETERANS_SUCCESS:
        return {
          ...state,
                      Severity: Minor
                      Found in src/applications/fry-dea/reducers.js - About 1 hr to fix

                        Function VAProfileInitError has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export function VAProfileInitError(props) {
  return (
    <VaAlert {...props} uswds>
      <h3 slot="headline">We can’t load some of your information</h3>
      <div>
                        Severity: Minor
                        Found in src/platform/user/profile/vap-svc/components/base/VAPServiceTransactionErrorBanner.jsx - About 1 hr to fix

                          Function renderSpecialtyTimes has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              const renderSpecialtyTimes = (existing = false) => {
      if (Array.isArray(healthAccessAttrs)) {
        // V1
        const healthAccessSpecialty = healthAccessAttrs.filter(
          acc => acc.service !== 'PrimaryCare',
                          Severity: Minor
                          Found in src/applications/facility-locator/components/AppointmentInfo.jsx - About 1 hr to fix

                            Function useServiceType has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            export default function useServiceType() {
  const dispatch = useDispatch();

  const selector = useSelector(
    state => state.drupalStaticData.vaHealthServicesData || [],
                            Severity: Minor
                            Found in src/applications/facility-locator/hooks/useServiceType.jsx - About 1 hr to fix

                              Function NeedHelp has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              export default function NeedHelp() {
  const isIntro = window.location.pathname.endsWith('/introduction');
  return isIntro ? (
    <>
      <p>
                              Severity: Minor
                              Found in src/applications/appeals/shared/content/NeedHelp.jsx - About 1 hr to fix

                                Function BurialInformation has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                export default function BurialInformation(props) {
  const { values, setFieldValue } = useFormikContext();

  useEffect(
    () => {
                                Severity: Minor
                                Found in src/applications/burial-poc-v6/pages/BurialInformation.jsx - About 1 hr to fix

                                  Function answerReview has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                  export const answerReview = (key, formValues) => {
  const ans = formValues[key];
  const dischargeYearLabel = prevApplicationYearCutoff[formValues['4_reason']];
  const monthObj = options.months.find(
    m => String(m.value) === formValues['3_dischargeMonth'],
                                  Severity: Minor
                                  Found in src/applications/discharge-wizard/helpers/index.jsx - About 1 hr to fix

                                    Function fetchFormsThunk has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                    export const fetchFormsThunk = (query, options = {}) => async dispatch => {
  // Derive options properties.
  const location = options?.location || window.location;
  const history = options?.history || window.history;
  const mockRequest = options?.mockRequest || false;
                                    Severity: Minor
                                    Found in src/applications/find-forms/actions/index.js - About 1 hr to fix

                                      Function applicantInsuranceThroughEmployerSchema has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                      export function applicantInsuranceThroughEmployerSchema(isPrimary) {
  const keyname = isPrimary
    ? 'applicantPrimaryThroughEmployer'
    : 'applicantSecondaryThroughEmployer';
  const provider = isPrimary
                                      Severity: Minor
                                      Found in src/applications/ivc-champva/10-7959C/chapters/healthInsuranceInformation.js - About 1 hr to fix

                                        Function HandlePrefilledSSN has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                        export default function HandlePrefilledSSN(fieldProps) {
  const props = vaTextInputFieldMapping(fieldProps);
  const [val, setVal] = useState(props.value);
  const [displayVal, setDisplayVal] = useState(props.value);
  const [cleared, setCleared] = useState(false);
                                        Severity: Minor
                                        Found in src/applications/ivc-champva/shared/components/maskSSN.jsx - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language